Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminals run hidden when reload window or close Visual Code. #35963

Closed
NhanNguyenPropolife opened this issue Oct 10, 2017 · 3 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) help wanted Issues identified as good community contribution opportunities terminal Integrated terminal issues
Milestone

Comments

@NhanNguyenPropolife
Copy link

  • VSCode Version: 1.17.0
  • OS Version: OSX 10.9.5

Steps to Reproduce:

  1. Run task(s)
  2. Reload the window/close window.
  3. All terminal disappears. But the tasks still running

Reproduces without extensions: Yes

When reload windows, I think we should keep all running terminals or ask to close them.
When close Visual Code, we should ask users if they want to close all them or not.

Sorry for my bad English.

@vscodebot vscodebot bot added new release terminal Integrated terminal issues labels Oct 10, 2017
@Tyriar Tyriar closed this as completed Oct 10, 2017
@Tyriar Tyriar reopened this Oct 10, 2017
@Tyriar
Copy link
Member

Tyriar commented Oct 10, 2017

@NhanNguyenPropolife what is the task you're using that causes this?

@Tyriar Tyriar added the info-needed Issue requires more information from poster label Oct 10, 2017
@NhanNguyenPropolife
Copy link
Author

NhanNguyenPropolife commented Oct 11, 2017

When I runs these tasks - Start Redis-server, MongoDB server, NGINX, Gunt
image
Then I reload the window to disable/enable an extension:
image
After reloading, all tasks in the terminal panel disappear. But the processes still running.
image

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities and removed info-needed Issue requires more information from poster labels Oct 11, 2017
@Tyriar Tyriar added this to the Backlog milestone Oct 11, 2017
@Tyriar
Copy link
Member

Tyriar commented Dec 28, 2017

Closing this in favor of:

@Tyriar Tyriar closed this as completed Dec 28, 2017
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 28, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) help wanted Issues identified as good community contribution opportunities terminal Integrated terminal issues
Projects
None yet
Development

No branches or pull requests

3 participants