Trashcan button kills entire terminal process tree including non-console apps

[the-ress]

• VSCode Version: Code - Insiders 1.17.0-insider (7ac1f1e, 2017-09-30T05:06:21.234Z)
• OS Version: Windows_NT x64 10.0.15063
• Extensions: none

---

Steps to Reproduce:

1. Open a non-console app from vscode terminal (e.g. notepad)
2. Kill the terminal using the trashcan button

Expected: Only the terminal process and any other processes attached to the console should be killed.
Actual: Entire process tree is killed, even non-console applications.

[Tyriar]

Yeah I introduced this earlier when trying to fix the process leak problem. Windows terminal support is my big focus in October so it should get resolved there 😃

[Tyriar]

Related #26807

[the-ress]

Thanks! This has been keeping me at 1.14. (The fix will ship with 1.18, right?)

[Tyriar]

1.14 o.0 you're missing a lot of good stuff.

Yes the fix is coming in 1.18 in early November.