Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lightbulb is only visible when you can see the first column #34603

Closed
Tyriar opened this issue Sep 18, 2017 · 4 comments
Closed

Lightbulb is only visible when you can see the first column #34603

Tyriar opened this issue Sep 18, 2017 · 4 comments
Assignees
@jrieken
Labels
editor-code-actions Editor inplace actions (Ctrl + .) under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 18, 2017

This means you cannot see that code actions are available when authoring relatively long lines on a narrow monitor.

screen shot 2017-09-19 at 8 00 55 am
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug editor-code-actions Editor inplace actions (Ctrl + .) labels Sep 19, 2017
@jrieken jrieken added this to the September 2017 milestone Sep 19, 2017
@jrieken
Copy link
Member

jrieken commented Sep 22, 2017

Tricky... The current idea of the lightbulb is to utilise the often occurring leading whitespace of a line. That doesn't work with horizontal scrolling. We have ideas to also show the lightbulb in the hover which might mitigate this.

@jrieken jrieken added under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues and removed bug Issue identified by VS Code Team member as probable bug labels Sep 22, 2017
@jrieken
Copy link
Member

jrieken commented Sep 22, 2017

/cc @stevencl

@jrieken jrieken removed this from the September 2017 milestone Sep 22, 2017
@stevencl
Copy link
Member

Yes, just commented on the original issue here: #25174 (comment).

Perhaps we should close this issue and keep the discussion going in the original?

@jrieken
Copy link
Member

jrieken commented Sep 22, 2017

Yeah, agreed. Closing as dupe of #25174

@jrieken jrieken closed this as completed Sep 22, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
editor-code-actions Editor inplace actions (Ctrl + .) under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stevencl @jrieken @Tyriar