Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using only one commit input field instead of multiple #33387

Closed
isidorn opened this issue Aug 29, 2017 · 2 comments
Closed

Consider using only one commit input field instead of multiple #33387

isidorn opened this issue Aug 29, 2017 · 2 comments
Assignees
Labels
git GIT issues

Comments

@isidorn
Copy link
Contributor

isidorn commented Aug 29, 2017

refs: #33267

  1. Have a MR workspace with multiple folders each having git
  2. Notice that for each of these we duplicate the commit input field.
  3. Due to this duplication we are loosing valuable screen space and it looks ugly on top of that

I propose that we only have one input field which would live on the top, seperated from the rest of the panes. This way the viewlet would be cleaner and nicer imho

@isidorn isidorn added the git GIT issues label Aug 29, 2017
@joaomoreno
Copy link
Member

We have considered. This first month is a way to get the changes out. Upcoming: #33363

@isidorn
Copy link
Contributor Author

isidorn commented Aug 29, 2017

I am not arguing here wheter to use a master / slave model or the current one. I am arguing that in both models we should use only one commit box

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
git GIT issues
Projects
None yet
Development

No branches or pull requests

2 participants