Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCM: hide views for repositories without changes #33334

Closed
bpasero opened this issue Aug 29, 2017 · 4 comments
Closed

SCM: hide views for repositories without changes #33334

bpasero opened this issue Aug 29, 2017 · 4 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@bpasero
Copy link
Member

bpasero commented Aug 29, 2017

I am not a big fan of how crowded the SCM view is now looking like by default, even if there are no changes in any of the other repositories:

image

The additional UI below the actual changes makes me always think there are more changes I need to take care of.

Can we not hide a view when there are no changes? Or collapse it by default?

@joaomoreno
Copy link
Member

This will make things very jumpy, as changes come and go... Definitely going to be a bad experience.

I suggest to simply collapse the repositories you don't use often. We can even add the change count to the header of each split view.

@joaomoreno joaomoreno added the info-needed Issue requires more information from poster label Aug 29, 2017
@sqs
Copy link

sqs commented Aug 29, 2017

Would you be interested in a PR that implemented a UI like this? I just hacked this together tonight.

The Open Repositories section works like the Open Editors section; it grows (to a point) based on the number of open repositories. Selecting a repository shows that repository's (and only that repository's) SourceControlView in the rest of the viewlet. Focus is in the Open Repositories list initially.

It would be fairly easy to make it possible to show multiple repositories' SourceControlViews if you multi-selected them. That would of course be duplicating some functionality of a viewlet's subviews (e.g., you could make it so right-clicking on the Source Control header would let you check/uncheck each repo, as in the extensions viewlet), but it seems quite convenient to make this always visible.

image

@joaomoreno
Copy link
Member

It's very interesting indeed. Let's move that here: #33363

@vscodebot vscodebot bot closed this as completed Sep 5, 2017
@vscodebot
Copy link

vscodebot bot commented Sep 5, 2017

This issue has been closed automatically because it needs more information and has not had recent activity. Please refer to our guidelines for filing issues. Thank you for your contributions.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

3 participants