Skip to content

Emmet suggestions is not at the top of the suggestion dialog #32256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pisarivskyi opened this issue Aug 10, 2017 · 1 comment
Closed

Emmet suggestions is not at the top of the suggestion dialog #32256

pisarivskyi opened this issue Aug 10, 2017 · 1 comment
Assignees
Labels
emmet Emmet related issues

Comments

@pisarivskyi
Copy link

pisarivskyi commented Aug 10, 2017

  • VSCode Version: 1.15.0 8b95971
  • OS Version: macOS Sierra 10.12.5, Windows 10

Fresh installation, without plugins.

Steps to Reproduce:

  1. Create .css or .scss file
  2. Start typing CSS rule ("w" for width, for example)
  3. At the top, you will get "white-space" suggestion.

This also works for the following rules:
h (height) -> height (but Emmet's abbreviation at the third place)
t (top) -> tab-size
l (left) -> left (but Emmet's abbreviation at the ninth place)
tac (text-align: center) -> touch-action
...and much more.

ttu not working, while tdn works just fine (Emmet's abbreviation at the first place)

Reproduces without extensions: Yes

To avoid this issue in the previous version, I've used these keybinding settings

{
        "key": "tab",
        "command": "tab",
        "when": "editorTextFocus && !editorTabMovesFocus"
},
{
        "key": "tab",
        "command": "editor.emmet.action.expandAbbreviation",
        "when": "editorTextFocus && !editorHasSelection && !editorHasMultipleSelections && !editorTabMovesFocus"
}

but now I'm getting an error:

"Warn: Running the contributed command:'emmet.expandAbbreviation' failed."

@vscodebot vscodebot bot added the emmet Emmet related issues label Aug 10, 2017
@ramya-rao-a
Copy link
Contributor

emmet css suggestions not always showing on top

The emmet suggestion is sorted alphabetically along with rest of the suggestions that are coming from css and so are showing up as they do. With #29113 we can look into ranking emmet higher.

"Warn: Running the contributed command:'emmet.expandAbbreviation' failed."

Previously, if tab was bound to emmet and there was no abbreviation to expand, there was a fallback to the normal tab that would add the indent.

In the current implementation, we have removed the default association of tab with emmet along with the said fallback.

Read the Emmet 2.0 blog for reasons as to why we went that route.

For your current situation, a quick workaround is to bind some other key (other than tab) to the Emmet expand abbreviation command, and you should be good to go.

To take part in the discussion on wanting the tab back, please participate in #32243

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
emmet Emmet related issues
Projects
None yet
Development

No branches or pull requests

2 participants