Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug Console suppressing URL output to stderr when line is of form "x.x:# http://x.x:#" #31330

Closed
jonathanfrisco opened this issue Jul 24, 2017 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s)

Comments

@jonathanfrisco
Copy link

  • VSCode Version: Code 1.14.2 (cb82feb, 2017-07-19T23:22:50.650Z)
  • OS Version: Darwin x64 15.6.0
  • Extensions:
Extension Author (truncated) Version
swagger-viewer Arj 1.4.0
vscode-markdownlint Dav 0.10.0
xml Dot 1.9.2
vscode-docker Pet 0.0.16
Bookmarks ale 0.15.2
code-gnu-global aus 0.2.2
githistory don 0.2.2
CppSnippets har 0.0.12
asciidoctor-vscode joa 0.3.5
vscode-insertdatestring jsy 2.1.0
Go luk 0.6.62
vscode-clang mit 0.2.2
mssql ms- 1.1.0
cpptools ms- 0.12.1
peep nwa 0.0.5
code-spell-checker str 1.3.2
gotimeformat v4r 1.0.1

Steps to Reproduce:

  1. Short Go program:
package main

import "fmt"
import "os"

func main() {
    fmt.Fprintln(os.Stderr, "x.y:1 http://x.y:1")
}

Should output: "x.y:1 http://x.y:1"
Outpust: "x.y:1 "
Running in terminal is fine and sending to stdout in debug console is also fine. If character(s) after colon are not numeric, fine, if http:// is not there, fine, if either period is not there, fine. Only when all conditions are met is the URL portion and everything after on line suppressed.

Reproduces without extensions: Cannot determine (need Go extension), but reproduces with ALL other extensions disabled.

@vscodebot vscodebot bot added the debug Debug viewlet, configurations, breakpoints, adapter issues label Jul 24, 2017
@weinand
Copy link
Contributor

weinand commented Jul 24, 2017

@isidorn I can reproduce this with node/node2 and the debug console. It works fine with the integrated terminal.

@weinand weinand assigned isidorn and unassigned weinand Jul 24, 2017
@weinand weinand added the bug Issue identified by VS Code Team member as probable bug label Jul 24, 2017
@isidorn
Copy link
Contributor

isidorn commented Jul 26, 2017

This is probably due to the link detection - since it is a link.
Giving to @michelkaporin - feel free to give back to me if you do not find time in you last week 😉

@isidorn isidorn assigned michelkaporin and unassigned isidorn Jul 26, 2017
@weinand
Copy link
Contributor

weinand commented Jul 26, 2017

Why is link detection destructive?

@michelkaporin
Copy link
Contributor

@isidorn thanks for that! Otherwise I can pick it up myself in my free time in the beginning of August as a PR :)

Seems that https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/debug/browser/linkDetector.ts#L82 this IF should be outside of while-loop.

@weinand unfortunately due to incorrect output string reconstruction.

@isidorn
Copy link
Contributor

isidorn commented Oct 27, 2017

Dup of #34026

@isidorn isidorn closed this as completed Oct 27, 2017
@isidorn isidorn added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 27, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

5 participants