Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save Workspace Only When You Click 'Closed Workspace' and Not When Closing VSCode #30974

Closed
Tekbr opened this issue Jul 19, 2017 · 9 comments
Closed
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code workbench-multiroot Multi-root (multiple folders) issues

Comments

@Tekbr
Copy link

Tekbr commented Jul 19, 2017

  • VSCode Version: 1.15.0 Insiders ( 3cfa565 , Date 2017-07-17T05:15:33.728Z)
  • OS Version: Windows 10

From #30608

@bpasero said that the intent would be to ask to save Workspace when the VSCode closed. In my view, this request should only be made when I click on 'Closed Workspace.' (It will be very uncomfortable to be forced to save when closing)

It should work the way it is in the current version, and when I use a single folder. If I close the VSCode when I open it again it returns in the state that it was.

Reproduces without extensions: Yes

@bpasero bpasero added feature-request Request for new features or functionality workbench-multiroot Multi-root (multiple folders) issues labels Jul 19, 2017
@bpasero
Copy link
Member

bpasero commented Jul 19, 2017

@Tekbr the consequence of that is that we need to show untitled workspaces throughout the UI (e..g File > Open Recent). Not sure how useful that is since these workspaces have no name.

@bpasero
Copy link
Member

bpasero commented Nov 17, 2017

Closing "as designed", no plans to change this currently.

@bpasero bpasero closed this as completed Nov 17, 2017
@Tekbr
Copy link
Author

Tekbr commented Nov 17, 2017

-- Sorry for the English, I used Google Translator --

@bpasero There is a moment we need to close everything running, for several reasons and being forced to save is very bad. Yet, it must be considered. Please reopen.

@bpasero
Copy link
Member

bpasero commented Nov 17, 2017

@Tekbr sorry, this is our issue clean up and some rules apply. We do not want to keep issues open that a) do not have lots of upvotes and b) are unlikely to get looked at for the next 6-12 months.

I am not inventing this clean up, it comes from #38268 so please complain there.

@bpasero
Copy link
Member

bpasero commented Nov 17, 2017

Given multi-root is a relatively new feature, I am willing to be less strict and wait for more user feedback. But please understand that this issue will not get much attention from me unless it ends up highly requested also from others.

@bpasero bpasero reopened this Nov 17, 2017
@Tekbr
Copy link
Author

Tekbr commented Nov 17, 2017

-- Sorry for the English, I used Google Translator --

@bpasero Anyway thank you. I still ask you to watch this case with care.

@vscodebot
Copy link

vscodebot bot commented Sep 11, 2018

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Sep 11, 2018
@Tekbr
Copy link
Author

Tekbr commented Sep 19, 2018

-- Sorry for the English, I used Google Translator --

@bpasero , in case #42657 it looks like @DavidLudwig was wanting to send a PR, I do not know if he came to see .. or could that question only be resolved by the members?

@mpressen
Copy link

really annoying and time-consuming to have to click on 'Don't Save' every time i decide to close a workspace.
I use them to have several instance of vs_code on different screens via 'Duplicate workspace in new window'.
Would love a checkbox to tick in order to not see it ever again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code workbench-multiroot Multi-root (multiple folders) issues
Projects
None yet
Development

No branches or pull requests

4 participants