Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Too many exclude settings #29629

Closed
isidorn opened this issue Jun 27, 2017 · 3 comments
Closed

Too many exclude settings #29629

isidorn opened this issue Jun 27, 2017 · 3 comments
Assignees
@roblourens @bpasero @Tyriar
Labels
*as-designed Described behavior is as designed settings-editor VS Code settings editor issues under-discussion Issue is under discussion for relevance, priority, approach
Milestone
Backlog

Comments

@isidorn
Copy link
Contributor

isidorn commented Jun 27, 2017 •
edited
Loading

Refs: #29478

Currently I feel like we have too many exclude settings in the settings.json, what is worse I am not sure what is their relation and which one applies where.

Do we really have user sceanrios that people want to fine grain this and that one exclude is not enough to bind them all?

files.exclude
files.watcherExclude
search.exclude
@bpasero
Copy link
Member

bpasero commented Jun 27, 2017

I consider files.watcherExclude a hack/workaround and not a typical use case. The others are valid imho, though the one (files.exclude) also applies to search.exclude. Maybe those two could be folded into one.

@bpasero bpasero added the under-discussion Issue is under discussion for relevance, priority, approach label Jun 27, 2017
@bpasero bpasero added this to the Backlog milestone Jun 27, 2017
@roblourens
Copy link
Member

I like the separate files/search.exclude because I want to see some files in the explorer, like node_modules and build output, but not search them. Also it's always been that way.

@bpasero bpasero added the settings-editor VS Code settings editor issues label Nov 11, 2017
@bpasero
Copy link
Member

bpasero commented Nov 15, 2017

Closing, "as designed".

@bpasero bpasero closed this as completed Nov 15, 2017
@bpasero bpasero added the *as-designed Described behavior is as designed label Nov 15, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@bpasero bpasero

@Tyriar Tyriar

Labels
*as-designed Described behavior is as designed settings-editor VS Code settings editor issues under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@roblourens @bpasero @isidorn @Tyriar