Multi root workspace explorer is not getting updated

[sandy081]

Testing #29478

• Set up a multi root workspace (Eg: vscode & vscode-docs)
• vscode-docs repository has incoming changes
• Pull changes in vscode-docs repo from another Editor (VS Code stable or terminal)

Expected above multi root workspace is updated with new additions/deletions of files. But not.

[sandy081]

Guess it is related to #29438 ?

[sandy081]

Also file content changes are not updated.

[sandy081]

Also adding a folder is not picked up

[bpasero]

@sandy081 any output when you run with --verbose?

[sandy081]

@bpasero I do not see any output when I change files in second root folder from outside. But I see events log in the console when I change files in first root folder from outside.

[bpasero]

@sandy081 I just tried exactly that scenario (had vscode master, docs and distro details) and did a git pull and the contents in the explorer got updated.

Can you share your settings? Does it reproduce from a clean VS Code (code-insiders --user-data-dir someDir...)

[sandy081]

@bpasero Nothing changed with new user data dir and also disabling extensions.

[bpasero]

@Tyriar I think you have a wrong check in https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/services/files/node/watcher/nsfw/nsfwWatcherService.ts#L161 for finding out if a folder is a child of another folder that is already watched. A simple indexOf will not do it. I suggest you use one of our helper functions: https://github.com/Microsoft/vscode/blob/master/src/vs/base/common/paths.ts#L359

[sandy081]

Good finding @bpasero 👍

For the workaround, as @bpasero suggested, I will use folders not starting with same name.

[Tyriar]

Good find 👍