Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not refresh explorer more than necessary, upon file events #29595

Closed
joaomoreno opened this issue Jun 27, 2017 · 2 comments
Closed

Do not refresh explorer more than necessary, upon file events #29595

joaomoreno opened this issue Jun 27, 2017 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues file-explorer Explorer widget issues *out-of-scope Posted issue is not in scope of VS Code perf
Milestone

Comments

@joaomoreno
Copy link
Member

Testing #29478

Currently, regardless of the file event, the whole explorer is refreshed.

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues labels Jun 27, 2017
@isidorn isidorn added this to the July 2017 milestone Jun 27, 2017
@isidorn isidorn modified the milestones: August 2017, July 2017 Jul 25, 2017
@isidorn isidorn modified the milestones: September 2017, August 2017 Aug 30, 2017
@isidorn isidorn modified the milestones: September 2017, October 2017 Sep 27, 2017
@isidorn
Copy link
Contributor

isidorn commented Sep 27, 2017

We currently react on both vscode internal file events and external file events.
On internal file events we are smart and refresh only what is needed but on external we refresh the whole tree.
This should be imrpoved by passing in what to referesh here

Pushing to october and debt

@isidorn isidorn added the debt Code quality issues label Sep 27, 2017
@isidorn isidorn modified the milestones: October 2017, Backlog Oct 10, 2017
@bpasero bpasero added the perf label Nov 11, 2017
@isidorn isidorn added the *out-of-scope Posted issue is not in scope of VS Code label Oct 8, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 8, 2019

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues file-explorer Explorer widget issues *out-of-scope Posted issue is not in scope of VS Code perf
Projects
None yet
Development

No branches or pull requests

3 participants