Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Expand button in search #28090

Closed
bakasmarius opened this issue Jun 6, 2017 · 5 comments · Fixed by #85428
Closed

Feature: Expand button in search #28090

bakasmarius opened this issue Jun 6, 2017 · 5 comments · Fixed by #85428
Assignees
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities search Search widget and operation issues
Milestone

Comments

@bakasmarius
Copy link

Hi all,

Currently when I search for a string and there are lots of results in lots of files, files with less than 10 results are automatically expanded. There is also a button "Collapse" that collapses all the files, but I can't seem to find a button to do the exact opposite - to expand all the files in search results. Could we get an "Expand" button please? It wouldn't even take up extra space - it could be shown instead of "Collapse" button when all files in search results are collapsed, and vice versa.

Thanks in advance, I use VSCode daily at work for half a year now and I'm really enjoying it!!

@sandy081 sandy081 self-assigned this Jun 6, 2017
@sandy081 sandy081 added search Search widget and operation issues feature-request Request for new features or functionality labels Jun 6, 2017
@sandy081 sandy081 added this to the Backlog milestone Jun 6, 2017
@sandy081 sandy081 removed their assignment Dec 4, 2017
@WilliamHolmes
Copy link

WilliamHolmes commented Jul 5, 2018

@sandy081 Is this Feature Request still on the radar?

@sandy081
Copy link
Member

sandy081 commented Jul 6, 2018

@roblourens FYI

@roblourens
Copy link
Member

This has come up before and I think we could investigate this now that search uses the new faster tree.

The main question is still, will expanding 10,000 files cause vscode to grind to a halt?

Someone could investigate this. I would consider having the "collapse" button actually toggle collapse/expand such that if everything is collapsed, it would switch to "expand all"

@roblourens roblourens added the help wanted Issues identified as good community contribution opportunities label Oct 8, 2019
@roblourens roblourens self-assigned this Oct 8, 2019
@JacksonKearl JacksonKearl self-assigned this Nov 4, 2019
@JacksonKearl
Copy link
Contributor

@roblourens can confirm that expanding 10,000 results (either in a couple files or across many) doesnt have a noticeable performance impact. Tested in Mac and Windows

@roblourens
Copy link
Member

Cool! It might still be useful to have this:

having the "collapse" button actually toggle collapse/expand such that if everything is collapsed, it would switch to "expand all"

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities search Search widget and operation issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants