Skip to content

IgnoreFile compares file paths in a case-sensitive way on windows/macOS #235478

New issue
New issue
Closed
#274232
Closed
IgnoreFile compares file paths in a case-sensitive way on windows/macOS#235478
#274232
Assignees
lramos15dmitrivMS
Labels
bugIssue identified by VS Code Team member as probable bugsearchSearch widget and operation issues
@benibenj

Description

@benibenj
benibenj
opened on Dec 6, 2024

IgnoreFile checks if a path belongs to a folder in the following way:

if (!path.startsWith(dirPath)) { return false; }

This does not take into account that paths are not case-sensitive on windows and macOS. Should it?

vscode/src/vs/workbench/services/search/common/ignoreFile.ts

Lines 117 to 125 in f9ec787

const isPathIgnored = (path: string, isDir: boolean) => {
if (!path.startsWith(dirPath)) { return false; }
if (isDir && isDirIgnored(path) && !isDirIncluded(path)) { return true; }
if (isFileIgnored(path) && !isFileIncluded(path)) { return true; }
if (parent) { return parent.isPathIgnored(path, isDir); }
return false;
};

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bugsearchSearch widget and operation issues

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions