Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.10.7] Should a developer's name show up in source for insiders build? #2688

Closed
rhires opened this issue Feb 4, 2016 · 2 comments
Closed
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@rhires
Copy link

rhires commented Feb 4, 2016

I know we're not talking release quality code, that this is still beta...but I do wonder if Insiders.app/Contents/Resources/app/extensions/jrieken.vscode-omnisharp/bin/omnisharp' with process id 47120... should be there. The error is that Omnisharp is not starting "[ERROR:OmniSharp.Dnx.DesignTimeHostManager] Failed to launch DesignTimeHost in a timely fashion."
But the main question is if code should include developers' names or be more generically named.

@jrieken jrieken self-assigned this Feb 4, 2016
@jrieken
Copy link
Member

jrieken commented Feb 4, 2016

Yeah, that's the publisher name the extension. We will make it proper soon.

@jrieken
Copy link
Member

jrieken commented Feb 4, 2016

closing as duplicate of dotnet/vscode-csharp#7

@jrieken jrieken closed this as completed Feb 4, 2016
@jrieken jrieken added *duplicate Issue identified as a duplicate of another issue(s) and removed *duplicate Issue identified as a duplicate of another issue(s) labels Apr 29, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

2 participants