Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do I theme the settings focus colors? #25459

Closed
Tyriar opened this issue Apr 26, 2017 · 2 comments
Closed

How do I theme the settings focus colors? #25459

Tyriar opened this issue Apr 26, 2017 · 2 comments
Assignees
Labels
info-needed Issue requires more information from poster themes Color theme issues
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 26, 2017

#25328

  • VSCode Version: Code - Insiders 1.12.0-insider (48ae6e3, 2017-04-26T06:32:53.505Z)
  • OS Version: Linux x64 4.10.0-19-generic
  • Extensions:
Extension Author Version
EditorConfig EditorConfig 0.9.3
lorem-ipsum Tyriar 1.0.0
sort-lines Tyriar 1.2.0
theme-sapphire Tyriar 0.1.0
vscode-svgviewer cssho 1.4.0
tslint eg2 0.12.0
git-project-manager felipecaputo 1.3.2
md-navigate jrieken 0.0.1
vscode-scss mrmlnc 0.6.2
vetur octref 0.6.3
seti-icons qinjia 0.1.3

focusedElementOutline is kind of what should drive it but it's named "Outline".

image

Also I think focusedElementOutline does drive the panel headings:

"focusedElementOutline": "#bbdaff"

image

@bpasero bpasero added this to the April 2017 milestone Apr 27, 2017
@bpasero
Copy link
Member

bpasero commented Apr 27, 2017

@Tyriar can you explain what you mean with "settings focus colors"?

@bpasero bpasero added themes Color theme issues workbench and removed workbench labels Apr 27, 2017
@bpasero
Copy link
Member

bpasero commented Apr 27, 2017

@Tyriar focusedElementOutline is the color used when you tab through elements in the UI to indicate focus. E.g. in high contrast theme this is the strong orange you see.

I will however revisit the name of this color, it may be confusing.

I am closing this, settings editor has not yet adopted theming at all.

@bpasero bpasero closed this as completed Apr 27, 2017
@bpasero bpasero added the info-needed Issue requires more information from poster label Apr 27, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster themes Color theme issues
Projects
None yet
Development

No branches or pull requests

2 participants