Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent naming for editor groups/tabs #25426

Closed
jrieken opened this issue Apr 26, 2017 · 0 comments
Closed

Inconsistent naming for editor groups/tabs #25426

jrieken opened this issue Apr 26, 2017 · 0 comments
Assignees
@bpasero
Labels
themes Color theme issues
Milestone
April 2017

Comments

@jrieken
Copy link
Member

jrieken commented Apr 26, 2017

re #25328

Below names are slightly confusing and don't follow the naming pattern used elsewhere. Either start with tabs or editor groups but not with an adjective.

// Workbench: Tabs
	"tabsContainerBackground": "",
	"tabBorder": "",
	"activeTabBackground": "",
	"inactiveTabBackground": "",
	"activeTabActiveGroupForeground": "",
	"activeTabInactiveGroupForeground": "",
	"inactiveTabActiveGroupForeground": "",
	"inactiveTabInactiveGroupForeground": "",
@bpasero bpasero added this to the April 2017 milestone Apr 26, 2017
@bpasero bpasero added themes Color theme issues workbench and removed workbench labels Apr 27, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
themes Color theme issues
Projects
None yet
Milestone
April 2017
Development

No branches or pull requests
3 participants
@bpasero @jrieken @aeschli