-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chrome debugger: Would be nice to see location of console messages #24490
Comments
This first needs to be added to the debug protocl in order to be supported, assigning to @weinand |
The feature request for the DAP already exists: microsoft/vscode-debugadapter-node#94 |
@roblourens can you estimate how much effort would it be to support this in the chrome debugger or node2? I am not sure if you just get it for free or how is chrome dev tools doing it? |
Every console message from the inspector debug protocol has an entire callstack attached - https://chromedevtools.github.io/devtools-protocol/v8/Runtime/#event-consoleAPICalled. I estimate... 20 minutes of work to implement microsoft/vscode-debugadapter-node#94 (comment) 😁 |
@roblourens great 😄 |
Let's move this out to June since it is dependent on microsoft/vscode-debugadapter-node#94 (comment) and we are in endgame |
Moving this to 'On-Deck' until we plan to implement this |
Currently this feature is not implemented neither by node or node2. In order to properly test this it would be great if one of the adapters would have the full implementation. fyi @roblourens created #34626 since node2 could support this |
Nice! |
Testing #24403
It would be nice if we could show the file + line number when we print a console message in the debug console. I have found this to be a nice way to jump between relevant locations while debugging.
Expected:
Actual:
The text was updated successfully, but these errors were encountered: