Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge link detection code between terminal, debug console and exception widget #24489

Closed
michelkaporin opened this issue Apr 11, 2017 · 3 comments
Assignees
Labels
debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues terminal General terminal issues that don't fall under another label
Milestone

Comments

@michelkaporin
Copy link
Contributor

michelkaporin commented Apr 11, 2017

Follow up on #24451.

This would also mean that debug console and exception widget will start recognising http links and paths without column (terminal regex would need general tweaking for the column case).

@michelkaporin michelkaporin added this to the Backlog milestone Apr 11, 2017
@michelkaporin michelkaporin self-assigned this Apr 11, 2017
@Tyriar
Copy link
Member

Tyriar commented Apr 17, 2017

Half the terminal link code is hidden inside xterm.js and the other half uses xterm.js' APIs, not sure how much can be reused. Terminal line/col PR out in #24832 since you looked at this recently you might want to give that a once over.

@Tyriar Tyriar added the debt Code quality issues label Apr 17, 2017
@michelkaporin
Copy link
Contributor Author

Thanks for the info on that, @Tyriar.

@michelkaporin michelkaporin added debug-console terminal General terminal issues that don't fall under another label labels Apr 18, 2017
@michelkaporin
Copy link
Contributor Author

I've looked at the terminal link detection code and it is very tightly connected to xterm.js as you've said, @Tyriar. Besides the code, there is no way to reuse the terminal regex unfortunately, because xterm.js provides its own link-detection regex, and we add ours on top of it for file paths, ending up using two regexes (with one coming from xterm.js).

Hence, closing this issue.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label May 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues terminal General terminal issues that don't fall under another label
Projects
None yet
Development

No branches or pull requests

3 participants