You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
michelkaporin opened this issue
Apr 11, 2017
· 3 comments
Assignees
Labels
debtCode quality issuesdebugDebug viewlet, configurations, breakpoints, adapter issuesterminalGeneral terminal issues that don't fall under another label
This would also mean that debug console and exception widget will start recognising http links and paths without column (terminal regex would need general tweaking for the column case).
The text was updated successfully, but these errors were encountered:
Half the terminal link code is hidden inside xterm.js and the other half uses xterm.js' APIs, not sure how much can be reused. Terminal line/col PR out in #24832 since you looked at this recently you might want to give that a once over.
I've looked at the terminal link detection code and it is very tightly connected to xterm.js as you've said, @Tyriar. Besides the code, there is no way to reuse the terminal regex unfortunately, because xterm.js provides its own link-detection regex, and we add ours on top of it for file paths, ending up using two regexes (with one coming from xterm.js).
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
debtCode quality issuesdebugDebug viewlet, configurations, breakpoints, adapter issuesterminalGeneral terminal issues that don't fall under another label
Follow up on #24451.
This would also mean that debug console and exception widget will start recognising http links and paths without column (terminal regex would need general tweaking for the column case).
The text was updated successfully, but these errors were encountered: