Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting to never close workspace even if files / folders outside it get opened #234371

Closed
j-lakeman opened this issue Nov 21, 2024 · 4 comments
Closed
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@j-lakeman
Copy link

Would be awesome if there was a setting say for the user settings.json to never close the “main” workspace. I find myself often in the situation of having to re-open my workspace file after calling VSCode as a merge or diff editor. Would be awesome if the workspace could always stay open even if VSCode gets called on files outside it.

@gjsjohnmurray
Copy link
Contributor

I wonder if what you're seeing is related to workspace trust.

What is your security.workspace.trust.untrustedFiles setting?

@j-lakeman
Copy link
Author

Definitely not, I disabled the setting. Not sure if we're talking about the same thing.

Steps to reproduce:

  1. have a workspace open in VSCode
  2. close the application
  3. open some file with VSCode outside the workspace (e.g. as diff or merge editor) (at this step the opened workspace is already closed)
  4. close VSCode again
  5. reopen VSCode
  6. editor's empty, workspace closed (offering to re-open it, but still it's a pain when working with Git a lot)

@bpasero
Copy link
Member

bpasero commented Nov 21, 2024

Can you try with window.restoreWindows set to preserve?

@bpasero bpasero added the info-needed Issue requires more information from poster label Nov 21, 2024
@j-lakeman
Copy link
Author

Awesome! That's exactly what I was looking for!
Sorry for the ruckus!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

3 participants