Rename 'textSearchProviderNew'

[roblourens]

Testing #226669

I recommend removing the New name from types before you start asking extensions to adopt the new API for real, to avoid the pain of handling unnecessary renames

[andreamah]

The problem is that moving the new APIs to the old names is tricky. TextSearchResult and TextSearchContext are now classes instead of interfaces. If people need to change the name for that anyways, I'm not sure if it's worth changing over others and making a half-transition.

[roblourens]

That doesn't seem like a problem, the interface doesn't exist at runtime, you can delete or rename old interfaces and expose the new classes without affecting any existing extensions.

[andreamah]

I think I had difficulty overloading the types when editing https://github.com/microsoft/vscode/blob/main/src/vs/workbench/api/common/extHost.api.impl.ts#L1510.

Is it possible to assign TextSearchMatch to either an interface or class here?

[roblourens]

The interfaces don't show up in extHost.api.impl, plus you can delete the old interfaces.

[andreamah]

The interfaces don't show up in extHost.api.impl, plus you can delete the old interfaces.

But I need to state TextSearchContext in extHost.api.impl, since it's now a class. But then it overloads the type of vscode.TextSearchContext. Would I need to call the old one TextSearchContextOld, then?

[roblourens]

You could delete the old one, since nobody should be writing new code that references it.