Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from findFiles to findFiles2New is a breaking API change #223279

Closed
alexr00 opened this issue Jul 23, 2024 · 1 comment
Closed

Upgrade from findFiles to findFiles2New is a breaking API change #223279

alexr00 opened this issue Jul 23, 2024 · 1 comment
Assignees
@andreamah

Comments

@alexr00
Copy link
Member

alexr00 commented Jul 23, 2024

Testing #223154

I'm sure you already know this, but upgrading from findFiles to findFiles2New is a breaking change since the first parameter goes from GlobPattern to GlobPattern[].
@andreamah
Copy link
Contributor

Yup! I was thinking of supporting both types (where the old one would be deprecated). I edited the original post to reflect this.

@andreamah andreamah closed this as not planned Won't fix, can't repro, duplicate, stale Jul 23, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@andreamah andreamah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andreamah @alexr00