Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review docs for issues and triage bot #219189

Open
FMorschel opened this issue Jun 28, 2024 · 3 comments
Open

Review docs for issues and triage bot #219189

FMorschel opened this issue Jun 28, 2024 · 3 comments
Assignees
Labels
issue-bot Issues concerning the issue bot! under-discussion Issue is under discussion for relevance, priority, approach

Comments

@FMorschel
Copy link

There are comments in old issues that never got the triage bot review, that ask what should happen then:

Hey, I saw that issue #198381 got a "VSCodeTriageBot" response and added to the backlog. How do we do that for old issues that existed before the TriageBot?
I know it's bad GitHub form, but I'm tempted to re-create this issue (linking to this one) so that we can ping the TriageBot with our votes. I think this vital feature has fallen into a black hole.

Originally posted by @J-Sorenson in #43026 (comment)

Some comments in other issues that mention the triage bot closing the issue without anyone revisiting it and reading the new comments for consideration:

@bpasero I think you should train your Tiragebot better. Closing this without acknowledging any of the later comment seems questionable

Originally posted by @escamoteur in #203326 (comment)

As well as a comment raised by me in this same issue questioning what happens when an issue is closed and then later gets to the 20 up-votes mark:

What happens now that it has already gained more than those 20 upvotes? Does it need a new mark? Will this not be considered then? If someone else wants this feature should they forget about it or should they create a new one? Those are not clear to me. Is there some place where these questions are documented (like a FAQ or something)?

Originally posted by @FMorschel in #203326 (comment)

Also, the docs mentioned by the triage bot don't ever say anything related to any of those things.

Summary

I guess that the questions here would be:

  • What happens with old opened issues that never got the triage bot review?
  • What happens to issues closed that people are still interested in? Should they get a new mark of up-votes or be recreated (I agree with @J-Sorenson and consider this a bad GitHub behaviour)?

I'm not sure this is the exact place for this, but if it isn't please let me know where it would fit.

@DanTup
Copy link
Contributor

DanTup commented Jul 1, 2024

What happens now that it has already gained more than those 20 upvotes?

Having to get 20 votes in a short period is particularly bad for extension-author requests because the pool of people voting on those is much smaller (it's not always obvious to users what a new extension API will do for them). Having the issues re-reviewed if they hit 20 votes later with be worthwhile IMO.

@FMorschel
Copy link
Author

FMorschel commented Dec 9, 2024

After trying to open #235517 as a new entry for four different old issues (#45385 being the original one) about the same thing I got at least one answer as to the preference here:

@jrieken:

It should have not been locked. I unlocked the original issue and I am closing this as duplicate.

So we now know that duplicates are not the way to go here. I still would like to know what should be done in these cases where the issues are closed @bhavyaus.

At least on the original issue, you pointed to this doc for out of scope requests and this is the message there:

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

There have been 7 comments on that issue after it got closed disagreeing that it got closed because the next message was:

@jrieken:

This is mostly covered with #45039 - which we have shipped a while back

And one of the comments got almost 20 up votes. As mentioned on #235517 we now have four different issues similar to that one and still nothing.

On the docs it says:

If you feel your feature request deserves to stay open, improve your use case or gather more up-votes. Then ping us and we'll consider reopening the feature request.

Here are the criteria we use to make the decision about closing a feature request:

  1. [...]
  2. Has the community at large expressed interest in this functionality? I.e. has it gathered more than 20 up-votes or more than 20 comments? This criterion alone covers more than 650 of the 2850 open feature requests as of right now, October 9th, 2019.

If this is something that can actually happen (you reopening the issues), I would expect this link (or even info) to be on every bot closure so people know that you need to be pinged again.

@jrieken
Copy link
Member

jrieken commented Dec 9, 2024

A couple of notes

  • we should generally not lock out-of-scope issues (I believe our bot had a bug for while cause this to happen)
  • users should not create duplicate issues, they loose all context and just create extra "noise" because folks don't know where to look for
  • users should not @-mention contributors just to draw attention to "the most important" issue. (This makes us unsubscribe from issues, wanna lock issues etc)
  • out-of-scope-closed and regular-closed issues are very different. The former are closed to make it simpler for us to manage the large body of issues

@rzhao271 rzhao271 added under-discussion Issue is under discussion for relevance, priority, approach issue-bot Issues concerning the issue bot! labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue-bot Issues concerning the issue bot! under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

6 participants