Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiles Editor: align with form layout/settings UI #218162

Closed
daviddossett opened this issue Jun 25, 2024 · 2 comments
Closed

Profiles Editor: align with form layout/settings UI #218162

daviddossett opened this issue Jun 25, 2024 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality on-testplan user-profiles User profile management ux User experience issues
Milestone

Comments

@daviddossett
Copy link
Contributor

Testing #217139

Related to other feedback I've given, here's a quick sketch of what I think gets us more aligned with things like the settings UI. Ideally we could even reuse the basic settings UI under the hood, but I don't know how portable it is off the top of my head. This isn't totally thought through but hopefully conveys the general idea I had in mind.

Main talking points:

  • Name and icon inputs are clearly labeled and have their own rows
  • Descriptions are added where needed
  • Actions are consolidated on the list item for each profile
  • Form actions are moved to the bottom
  • Table gets a name/description

CleanShot 2024-06-25 at 11 06 49@2x

@sandy081
Copy link
Member

Thanks for the feedback. I like it is aligned with Settings UI and will incorporate these changes in the next milestone.

@sandy081 sandy081 added feature-request Request for new features or functionality ux User experience issues user-profiles User profile management labels Jun 27, 2024
@sandy081 sandy081 added this to the July 2024 milestone Jun 27, 2024
@sandy081
Copy link
Member

Regarding primary actions on the profile in the LHS, I think New Window should be the only primary action and other should be in the overflow.

@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality on-testplan user-profiles User profile management ux User experience issues
Projects
None yet
Development

No branches or pull requests

3 participants