Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Electron 29 update #210886

Closed
3 tasks done
deepak1556 opened this issue Apr 22, 2024 · 6 comments
Closed
3 tasks done

Test: Electron 29 update #210886

deepak1556 opened this issue Apr 22, 2024 · 6 comments

Comments

@deepak1556
Copy link
Collaborator

deepak1556 commented Apr 22, 2024

Refs: #210467

Complexity: 3

Create Issue


We plan to promote Electron 29 in the May 2024 milestone to insiders. The following tests cover some of the common UI bits that don't have smoke tests. You can download the nightly explorations builds from here for testing.

Testing:

  • macOS:

    • Enable Native Tabs (via settings: window.nativeTabs: true)
      • Ensure native tabs are enabled in the system preferences (System Preferences > General > Prefer tabs: "always":)
      • Launch application
      • Try opening new window from either command line (code-exploration ) or from the menu entry (Cmd + Shift + N)
      • Verify new window is launched as a new tab in the active instance of the application window is focused when starting from command line
      • open the code exploration application from finder or dock
      • open external terminal
      • run code-exploration
      • make sure the new window is put to foreground
  • windows:

    • verify maximize and restore operations work as expected when OS task bar is auto-hidden for custom titlebar
    • Verify titlebar is not clipped off when exiting fullscreen
      • Maximize VS Code window
      • Press F11 or Ctrl+K Z twice to enter/exit full screen.
      • Verify titlebar is not cropped
  • All OS:

    • Check out the electron-29.x.y branch locally and verify you can run out of sources, set a breakpoint and debug using the VS Code launch configurations and VS Code debugger
@justschen
Copy link
Contributor

justschen commented Apr 23, 2024

@deepak1556 on macos, when closing multiple windows that are grouped, when reopened, should they be split or grouped? other than that, everything works as expected.

@justschen justschen removed their assignment Apr 23, 2024
@deepak1556
Copy link
Collaborator Author

Depends on the setting value for Prefer tabs when opening documents, if it is set to "always" then the windows should be grouped on restart.

@aeschli
Copy link
Contributor

aeschli commented Apr 23, 2024

@deepak1556 There's currently no Linux build published for explorations: https://builds.code.visualstudio.com/builds/exploration?released=true&dev=true
I'll run from sources...

@deepak1556
Copy link
Collaborator Author

Sorry yeah there is no x64 linux available at this time due to a pending runtime update, please use the arm flavor if possible. Otherwise just testing from the sources is fine for this item.

@ntrogh ntrogh removed their assignment Apr 23, 2024
@ntrogh
Copy link
Contributor

ntrogh commented Apr 23, 2024

Works as expected on Windows.

@aeschli
Copy link
Contributor

aeschli commented Apr 23, 2024

Running from sources all seems to work as usual on Linux.
Unfortunately the open dialogs are still behind the windows. Would be great if this could get some priority.

@aeschli aeschli removed their assignment Apr 23, 2024
@aeschli aeschli closed this as completed Apr 23, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants