-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimap: Implement dragging the minimap slider. #20935
Comments
I'm happy to help and work on a PR if you are able to offer me hints and some guidance on how to make this work. Great job getting minimap out. The big fat scrollbar is a great UX experience that I absolutely love about sublime. |
If this is implemented I think it would make sense to allow disabling the current scrollbar. Another related thing that comes to my mind would be a setting to be able hide the minimap if the window is narrower than a set character width. But I guess that should be a separate sub issue? |
@ristomatti As an option, maybe, but the scrollbar has more information than the minimap does - for example it shows you changes since last commit, etc. |
@martin-wiseweb Yes exactly. On some occasions it's useful to have an overview of what is changed, but on some it's more useful to have the ability to quickly move around the files. I too often find myself in a situation where I'd like to either have a browser window (reference/something I'm working on) or another code panel open side by side but cannot comfortably do so. This can be because the site does not wrap text and requires a wide view to show everything in a readable font size or if the codebase does not enforce limiting the columns to a decent width. This is where it becomes important to be able to configure the editor to only show the parts I need the most. Usually I work on a 27" screen so this is not an issue with the screen estate. I would also like to note that nothing prevents from including similar visual cues on the minimap that are currently found on the scrollbar. This could done with an overlay shading or simply a thin line on the side of the minimap. |
@ristomatti Let's explore painting more than just characters in the minimap in #20934. As a follow-up we can then explore if the overview ruler is redundant. I intend to close this issue once dragging the slider is implemented. |
I noticed dragging the minimap slider does not seem to work if you start the drag by clicking outside the highlighted area, is this a bug? |
Perhaps also render it only on minimap hover (or have it as an option).
The text was updated successfully, but these errors were encountered: