Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimap: Implement dragging the minimap slider. #20935

Closed
alexdima opened this issue Feb 20, 2017 · 7 comments
Closed

Minimap: Implement dragging the minimap slider. #20935

alexdima opened this issue Feb 20, 2017 · 7 comments
Assignees
Labels
editor-minimap Code/Text minimap widget issues
Milestone

Comments

@alexdima
Copy link
Member

Perhaps also render it only on minimap hover (or have it as an option).

@alexdima alexdima self-assigned this Feb 20, 2017
@alexdima alexdima added the editor-minimap Code/Text minimap widget issues label Feb 20, 2017
@nojvek
Copy link
Contributor

nojvek commented Feb 20, 2017

I'm happy to help and work on a PR if you are able to offer me hints and some guidance on how to make this work.

Great job getting minimap out.

The big fat scrollbar is a great UX experience that I absolutely love about sublime.

@CoenraadS
Copy link
Contributor

CoenraadS commented Feb 20, 2017

Would it also be possible to have it extend all the way to the bottom of the editor? Similar to visual studio:
image

If I want to go to the bottom of a file, I just want to click the end of the scroll bar. But in small files, the end of the scroll bar is half-way up the screen..

@ristomatti
Copy link
Contributor

If this is implemented I think it would make sense to allow disabling the current scrollbar.

Another related thing that comes to my mind would be a setting to be able hide the minimap if the window is narrower than a set character width. But I guess that should be a separate sub issue?

@martin-sweeny
Copy link

@ristomatti As an option, maybe, but the scrollbar has more information than the minimap does - for example it shows you changes since last commit, etc.

@ristomatti
Copy link
Contributor

@martin-wiseweb Yes exactly. On some occasions it's useful to have an overview of what is changed, but on some it's more useful to have the ability to quickly move around the files.

I too often find myself in a situation where I'd like to either have a browser window (reference/something I'm working on) or another code panel open side by side but cannot comfortably do so. This can be because the site does not wrap text and requires a wide view to show everything in a readable font size or if the codebase does not enforce limiting the columns to a decent width. This is where it becomes important to be able to configure the editor to only show the parts I need the most. Usually I work on a 27" screen so this is not an issue with the screen estate.

I would also like to note that nothing prevents from including similar visual cues on the minimap that are currently found on the scrollbar. This could done with an overlay shading or simply a thin line on the side of the minimap.

@alexdima
Copy link
Member Author

@ristomatti Let's explore painting more than just characters in the minimap in #20934. As a follow-up we can then explore if the overview ruler is redundant.

I intend to close this issue once dragging the slider is implemented.

@mickdekkers
Copy link

I noticed dragging the minimap slider does not seem to work if you start the drag by clicking outside the highlighted area, is this a bug?

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-minimap Code/Text minimap widget issues
Projects
None yet
Development

No branches or pull requests

6 participants