Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use ALT+up/down to switch between search file filters #20547

Closed
Srekel opened this issue Feb 13, 2017 · 4 comments
Closed

Can't use ALT+up/down to switch between search file filters #20547

Srekel opened this issue Feb 13, 2017 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality search Search widget and operation issues verification-found Issue verification failed verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@Srekel
Copy link

Srekel commented Feb 13, 2017

  • VSCode Version: Code 1.9.1 (f9d0c68, 2017-02-09T00:26:45.394Z)
  • OS Version: Windows_NT ia32 10.0.14393
  • Extensions:
Extension Author Version
vscode-whitespacer deerawan 1.0.0
contextualduplicate lafe 0.2.0
cpptools ms-vscode 0.9.2
csharp ms-vscode 1.6.2
duplicatetext rivenvirus 0.0.3
trailing-spaces shardulm94 0.2.11
vscode-fileutils sleistner 2.3.3
shader slevesque 0.2.2
cmake twxs 0.0.15

Steps to Reproduce:

  1. Open Find in Files.
  2. Go to the "files to include" box.
  3. Make sure you've searched before with different file filters.
  4. Press ALT + up/down arrow.

Expected result: Switch between previous file filters.
Result: Active line is moved.

I'm not sure if this is a missing feature or a bug, but I'm pretty sure it worked pre-1.9. (It works in Sublime and is something I use quite frequently)

codebug_search_alt

@sandy081
Copy link
Member

Navigating history is only supported on Search field.

@sandy081
Copy link
Member

Fixed by the PR #27476

Verify:

History navigation in include and exclude text boxes using Alt + up and Alt +down keys.
History is remembered between window reloads

@sandy081 sandy081 modified the milestones: July 2017, Backlog Jul 25, 2017
@roblourens roblourens added the verification-needed Verification of issue is requested label Aug 1, 2017
@chrmarti
Copy link
Collaborator

chrmarti commented Aug 2, 2017

Trying to verify, I've searched including once *.js and once *.txt. I'd expect both to be in the history, but only *.txt shows up.

  • VSCode Version: Code - Insiders 1.15.0-insider (211ffdf, 2017-08-02T05:07:49.324Z)
  • OS Version: Darwin x64 16.6.0
  • Extensions: none

@chrmarti chrmarti reopened this Aug 2, 2017
@chrmarti chrmarti added the verification-found Issue verification failed label Aug 2, 2017
@roblourens
Copy link
Member

It only saves the history on a navigate action, when it should save on search submit

@Lixire Lixire added the verified Verification succeeded label Aug 4, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality search Search widget and operation issues verification-found Issue verification failed verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants