Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird structure of Issue Reporter command arguments #203151

Closed
isidorn opened this issue Jan 23, 2024 · 0 comments · Fixed by #204024
Closed

Weird structure of Issue Reporter command arguments #203151

isidorn opened this issue Jan 23, 2024 · 0 comments · Fixed by #204024
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Jan 23, 2024

Testing #203094

Current calling structure is

vscode.commands.executeCommand('workbench.action.openIssueReporter', {
		extensionId: 'ms-python.python',
		issueTitle: 'title here',
		command: {
			template: templateString,
			data: dataString,
			uri: Uri.parse('https://github.com/microsoft/vscode-copilot-release').toString(), // changed url here for demo
		}
	});

I find that the command section introduces strange grouping. Is it really needed, could all the fields be top level?
What is the benefit of having it be structured in the current way?

@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Feb 1, 2024
@vscodenpa vscodenpa added this to the February 2024 milestone Feb 1, 2024
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 2, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants