Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Code Actions on Save Behavior #194957

Closed
justschen opened this issue Oct 6, 2023 · 0 comments
Closed

Test: Code Actions on Save Behavior #194957

justschen opened this issue Oct 6, 2023 · 0 comments
Assignees

Comments

@justschen
Copy link
Contributor

justschen commented Oct 6, 2023

tests candidate for #194861.
insiders PR (when released): #194870
release branch PR: #194930

Things to test:

  1. Search in settings for Code actions on save
  2. edit in settings.json
  3. Test scenarios for explicit, always, and never when saving normally, and do so again when Auto Save is enabled for Window change and Focus Change, as well as when Auto Save is enabled after delay (in which case nothing would happen).
  4. Test scenarios for true and false in same conditions.
  5. Code Actions with the array (ensure no error, runs like true and false).
  6. Edge Cases: Scenarios like ESLint codeActionsOnSave not work #194978 where multiple types of source actions are used.

Example for arrays:

"editor.codeActionsOnSave": [
    "editor.formatOnSave",
    "source.organizeImports",
    "source.sortImports",
    "source.fixAll"
  ]

Runs when code actions are in the array, does not run when code actions are excluded from the array.

Known issues:

@justschen justschen added the candidate Issue identified as probable candidate for fixing in the next release label Oct 6, 2023
@justschen justschen self-assigned this Oct 6, 2023
@justschen justschen added the unreleased Patch has not yet been released in VS Code Insiders label Oct 6, 2023
@justschen justschen removed candidate Issue identified as probable candidate for fixing in the next release unreleased Patch has not yet been released in VS Code Insiders labels Oct 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant