Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick a forever theme color for the quick fix highlight and allow styling both background and borders #194225

Open
Tyriar opened this issue Sep 26, 2023 · 3 comments
Assignees
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 26, 2023

Testing #194072

We cover bg and border for the majority of highlights, for example:

		"editor.lineHighlightBorder": "#263040",
		"editor.rangeHighlightBackground": "#ffffff0d",
		"editor.selectionBackground": "#399ef440",
		"editor.selectionHighlightBackground": "#399ef420",
		"editor.wordHighlightBackground": "#00000000",
		"editor.wordHighlightBorder": "#399ef4",
		"editor.wordHighlightStrongBackground": "#00000000",
		"editor.wordHighlightStrongBorder": "#399ef4",

We should look into whether one of those is suitable and use that, or make our own and choose a good base to derive from. Provided there's no conflicts, I'll likely make my theme use the bright accent border I use for word highlight:

Image

We want to make sure that it behaves correctly when there is for example find in files, find in the current file, etc. already active.

@justschen
Copy link
Contributor

example here (since i'm using 'editor.findMatchHighlightBackground` with no changes):

Screenshot 2023-10-03 at 10 38 04 AM

@justschen justschen added this to the Backlog milestone Dec 6, 2023
@justschen
Copy link
Contributor

will be addressed as part of #199608

@Tyriar
Copy link
Member Author

Tyriar commented Dec 7, 2023

@justschen that looks like it's more API related, you sure you want to combine them as this ask could get lost? Smaller scoped issues are always easier to deal with imo.

@justschen justschen reopened this Dec 7, 2023
@justschen justschen modified the milestones: Backlog, December 2023/January 2024 Dec 7, 2023
@justschen justschen modified the milestones: December / January 2024, Backlog Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants