Slow closing time. The app will close the new instance when opened before it fully closes.

[dhirajgagrai]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version:

Version: 1.82.2 (Universal)
Commit: abd2f3db4bdb28f9e95536dfa84d8479f1eb312d
Date: 2023-09-14T05:59:47.790Z (3 days ago)
Electron: 25.8.1
ElectronBuildId: 23779380
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Darwin arm64 22.6.0

• OS Version:

macOS Ventura 13.5

Steps to Reproduce:

1. Quit VSCode.
2. The indicator is present there for a while before it fully quits.

Sometimes, it takes upto 3-5 seconds to complete the quitting process. If I open the app before it quits, the app closes shortly after and indicator is also gone.
I started noticing this issue after updating the app last time.

[dhirajgagrai]

[main 2023-09-17T16:40:06.311Z] Lifecycle#quit() - begin (willRestart: undefined)
[main 2023-09-17T16:40:06.311Z] Lifecycle#quit() - calling app.quit()
[main 2023-09-17T16:40:06.312Z] Lifecycle#app.on(before-quit)
[main 2023-09-17T16:40:06.312Z] Lifecycle#onBeforeShutdown.fire()
[main 2023-09-17T16:40:06.312Z] [WindowsStateHandler] onBeforeShutdown {
  lastActiveWindow: {
    workspaceIdentifier: undefined,
    folder: 'file:///Users/maoth/Projects/prime',
    ba/vs/workbench/workbench.desktop.main.js (630)
ckupPath: '/Users/maoth/Library/Application Support/Code/Backups/e8b97b2cca7f7b41a549189906bc8117',
    remoteAuthority: undefined,
    uiState: [Object: null prototype] {
      mode: 1,
      x: 0,
      y: 160,
      width: 1470,
      height: 860
    }
  },
  lastPluginDevelopmentHostWindow: undefined,
  openedWindows: []
}
[main 2023-09-17T16:40:06.313Z] Lifecycle#window.on('close') - window ID 1
[main 2023-09-17T16:40:06.313Z] Lifecycle#unload() - window ID 1
[33019:0917/221006.417317:INFO:CONSOLE(630)] "%cTRACE color: #888 [lifecycle] onBeforeUnload (reason: 2)", source: vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js (630)
[33019:0917/221006.421031:INFO:CONSOLE(630)] "%cTRACE color: #888 [lifecycle] onBeforeUnload continues without veto", source: vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js (630)
[33019:0917/221006.421577:INFO:CONSOLE(630)] "%cTRACE color: #888 [lifecycle] onWillUnload (reason: 2)", source: vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js (630)
[main 2023-09-17T16:40:06.433Z] Lifecycle#onBeforeCloseWindow.fire() - window ID 1
[main 2023-09-17T16:40:06.442Z] IPC Object URL: Removed channel vscode:918b3ae4-8d8f-406e-be8b-9b0195196146.
[main 2023-09-17T16:40:06.443Z] Lifecycle#window.on('closed') - window ID 1
[main 2023-09-17T16:40:06.443Z] Lifecycle#onWillShutdown.fire()
[main 2023-09-17T16:40:06.443Z] Lifecycle#onWillShutdown - begin 'instanceLockfile'
[main 2023-09-17T16:40:06.444Z] storageMainService#onWillShutdown()
[main 2023-09-17T16:40:06.444Z] Lifecycle#onWillShutdown - begin 'applicationStorage'
[main 2023-09-17T16:40:06.444Z] Lifecycle#onWillShutdown - begin 'workspaceStorage'
[main 2023-09-17T16:40:06.444Z] [UtilityProcess id: 1, type: extensionHost, pid: 33028]: waiting to exit...
[main 2023-09-17T16:40:06.444Z] Lifecycle#onWillShutdown - begin 'extHostStarter'
[main 2023-09-17T16:40:06.444Z] [UtilityProcess id: 1, type: fileWatcher, pid: 33027]: attempting to kill the process...
[main 2023-09-17T16:40:06.447Z] [UtilityProcess id: 1, type: fileWatcher, pid: 33027]: successfully killed the process
[main 2023-09-17T16:40:06.447Z] Lifecycle#app.on(window-all-closed)
[main 2023-09-17T16:40:06.448Z] Lifecycle#app.on(will-quit) - begin
[main 2023-09-17T16:40:06.454Z] [File Watcher (node.js)] Request to stop watching: /Users/maoth/Library/Application Support/Code/User,/Users/maoth/Library/Application Support/Code/User/settings.json
[main 2023-09-17T16:40:06.454Z] [File Watcher (node.js)] stopping file watcher on /Users/maoth/Library/Application Support/Code/User
[main 2023-09-17T16:40:06.455Z] [File Watcher (node.js)] stopping file watcher on /Users/maoth/Library/Application Support/Code/User/settings.json
[main 2023-09-17T16:40:06.455Z] Lifecycle#onWillShutdown - end 'instanceLockfile'
[main 2023-09-17T16:40:06.455Z] [UtilityProcess id: 1, type: fileWatcher, pid: 33027]: received exit event with code 0
[main 2023-09-17T16:40:06.455Z] [UtilityProcessWorker]: terminated normally with code 0, signal: unknown
[main 2023-09-17T16:40:06.459Z] StorageMainService: closed workspace storage (7e8ce32e46cead1838b5be57cf622434)
[main 2023-09-17T16:40:06.459Z] Lifecycle#onWillShutdown - end 'workspaceStorage'
[main 2023-09-17T16:40:06.460Z] StorageMainService: closed application storage
[main 2023-09-17T16:40:06.460Z] Lifecycle#onWillShutdown - end 'applicationStorage'
[main 2023-09-17T16:40:08.325Z] resolveShellEnv(): skipped (VSCODE_CLI is set)
[main 2023-09-17T16:40:11.440Z] [UtilityProcess id: 1, type: extensionHost, pid: 33028]: received exit event with code 0
[main 2023-09-17T16:40:11.441Z] Extension host with pid 33028 exited with code: 0, signal: unknown.
[main 2023-09-17T16:40:11.441Z] Lifecycle#onWillShutdown - end 'extHostStarter'
[main 2023-09-17T16:40:11.444Z] Lifecycle#app.on(will-quit) - after fireOnWillShutdown
[main 2023-09-17T16:40:11.444Z] Lifecycle#app.on(will-quit) - calling app.quit()
[main 2023-09-17T16:40:11.445Z] [UtilityProcess type: ptyHost, pid: 33029]: received exit event with code 0

These are the verbose messages when quitting. It took ~ 5 seconds in total to quit. All the extensions were disabled.

[deepak1556]

/duplicate #192742