Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing common properties in extension telemetry when logging error event #193205

Closed
Joouis opened this issue Sep 15, 2023 · 3 comments
Closed

Missing common properties in extension telemetry when logging error event #193205

Joouis opened this issue Sep 15, 2023 · 3 comments
Assignees

Comments

@Joouis
Copy link

Joouis commented Sep 15, 2023

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.82.2
  • OS Version: macOS Ventura 13.5.2

Steps to Reproduce:

  1. Install the @vscode/extension-telemetry, then use this extension in any other extension, for example we're building Prompt flow for VS Code now.
  2. Trigger any uncaught error in our own extension.
  3. Check the Kusto query result of configured App Insight service.
image

This is not the first issue I submitted, actually I found unsanitized issue before and @lramos15 helped to fixed it. I also learned from his PR then take a deep look today to figure out if this bug is belong to the telemetry extension or the VSCode host. After the investigation, not only submit a issue here, I will also create a PR to fix it ASAP. For more technical details, I will describe in the PR.

@VSCodeTriageBot VSCodeTriageBot added the stale Issues that have not been triaged in an appropriate amount of time label Sep 26, 2023
@rebornix rebornix assigned lramos15 and unassigned rebornix Oct 5, 2023
@VSCodeTriageBot VSCodeTriageBot removed triage-needed stale Issues that have not been triaged in an appropriate amount of time labels Oct 5, 2023
@Joouis
Copy link
Author

Joouis commented Oct 16, 2023

Ignore that my PR is under reviewing for a month (I understand that this issue may not be high priority to dev team), but the issue has been bothering us for a while, and definitely same to other extension developers.

Our extension has just been lanuched, so there will be some unhandled errors, of course we want to improve the quality by tracking and fixing them quickly.

However current situation is that the error stack has been redacted, and we don't even know the specific version of extension that customer was using, thus is really hard to locate the problem, let alone the root cause 😢

@rebornix Or maybe we should discuss the priority and if there is timeline for the issue firstly... Also I don't blame Logan since he explained that he had a lot of work recently, any other telemetry expert could help on this?

@Joouis
Copy link
Author

Joouis commented Oct 16, 2023

We also have a table showing the version where the error first and last occurred for investigation. And it doesn't work for unhandled error.
image

@lramos15
Copy link
Member

lramos15 commented Dec 5, 2023

This should be fixed by microsoft/vscode-extension-telemetry#191

@lramos15 lramos15 closed this as completed Dec 5, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants