Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS: Trouble quitting VS Code (stable + insider) #192753

Closed
rojadesign opened this issue Sep 11, 2023 · 4 comments
Closed

MacOS: Trouble quitting VS Code (stable + insider) #192753

rojadesign opened this issue Sep 11, 2023 · 4 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@rojadesign
Copy link

rojadesign commented Sep 11, 2023

Does this issue occur when all extensions are disabled?: Yes

Type: Performance Issue

This is a regression of #172967.

  • VS Code Stable: 1.82.0 (latest)
  • VS Code Insider: 1.83.0-insider (latest)
  • OS Version: MacOS Ventura 13.5.2
  • Macbook Pro M1 2021

VS Code has trouble quitting with the cmd+Q shortcut on macOS. When I use cmd+Q or quit it by using the menu, VS Code hangs and remains open for some time. I can tell that VS Code is open by the indicator dot under its icon in the dock. Also, after quitting, I can open VS Code again before it quits completely - then it will kill both instances, of course. But all of that is described in #172967 thoroughly.

Steps to reproduce:

  • Open VS Code on macOS
  • use cmd+Q to quit VS Code
  • Notice that the "Code" title in the macOS menubar flashes
  • Notice the dot under VS Code's icon in the dock and that VS Code remains open

Only solution for now is to disable telemetry as suggested in #172967 (comment).

@jungaretti @klaussner FYI, would be interesting if you can reproduce this.

@klaussner
Copy link

I could reproduce the issue with 1.83.0-insider. 👍

@jungaretti
Copy link

Yes, I'm able to reproduce this consistently on 1.83.0-insider

Screen Recording

vscode-log-1694451354.mp4

Logs

code-insiders --disable-extensions --user-data-dir "$(mktemp -d)" --verbose &> "$HOME/Desktop/vscode-log-$(date +%s).txt"

vscode-log-1694451354.txt

Info

Version: 1.83.0-insider (Universal)
Commit: 3c133b63c6e17e2fe33f37db93a6d43e78a262c5
Date: 2023-09-11T05:34:30.222Z
Electron: 25.8.0
ElectronBuildId: 23503258
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Darwin arm64 22.6.0

@jungaretti
Copy link

This feels more pervasive than #172967. That one was tricky to reproduce. This issue happnes every time I Cmd+Q to quit VS Code.

@deepak1556
Copy link
Collaborator

/duplicate #192742

@vscodenpa vscodenpa added the *duplicate Issue identified as a duplicate of another issue(s) label Sep 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

6 participants