Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task reuse of terminal is inconsistent #19251

Closed
Tyriar opened this issue Jan 24, 2017 · 2 comments
Closed

Task reuse of terminal is inconsistent #19251

Tyriar opened this issue Jan 24, 2017 · 2 comments
Assignees
Labels
tasks Task system issues

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 24, 2017

Testing #19057

  • VSCode Version: Code - Insiders 1.9.0-insider (4265f5e, 2017-01-24T10:29:13.076Z)
  • OS Version: Darwin x64 16.3.0
  • Extensions:
Extension Author Version
EditorConfig EditorConfig 0.3.4
lorem-ipsum Tyriar 1.0.0
sort-lines Tyriar 1.2.0
theme-glacier Tyriar 0.0.10
vscode-svgviewer cssho 1.3.0
gitlens eamodio 1.4.3
git-project-manager felipecaputo 1.0.1
md-navigate jrieken 0.0.1
vscode-scss mrmlnc 0.6.0
seti-icons qinjia 0.1.3

I ran 4 lint tasks, only the 3rd one reused the 2nd terminal instance.

screen shot 2017-01-24 at 10 31 36 am

@dbaeumer dbaeumer added this to the February 2017 milestone Jan 25, 2017
@dbaeumer dbaeumer added tasks Task system issues bug Issue identified by VS Code Team member as probable bug labels Jan 25, 2017
@dbaeumer dbaeumer modified the milestones: February 2017, March 2017 Feb 17, 2017
@dbaeumer
Copy link
Member

I improved the behavior for March by having a primary terminal that is always resued. However there is more to do here before I can close this:

  • allow users to control this. This is requested in other issues as well
  • reuse a terminal id idle if marked to be able to. For example users want to mark a terminal to not be resued to for example don't loose the result of a test run.

@dbaeumer dbaeumer modified the milestones: April 2017, March 2017 Mar 27, 2017
@dbaeumer dbaeumer added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Mar 27, 2017
@dbaeumer dbaeumer modified the milestones: On Deck, April 2017 Apr 13, 2017
@dbaeumer
Copy link
Member

dbaeumer commented Nov 9, 2017

This got improved in the final implementation by giving the user a property to control this. It can either be 'shared', 'dedicated', 'new'. If shared the terminal is shared between all tasks, if dedicated it is only shared between runs of the same task and if new it is never shared.

@dbaeumer dbaeumer closed this as completed Nov 9, 2017
@dbaeumer dbaeumer removed the feature-request Request for new features or functionality label Nov 9, 2017
@dbaeumer dbaeumer removed this from the On Deck milestone Nov 9, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tasks Task system issues
Projects
None yet
Development

No branches or pull requests

2 participants