Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test project wide JS/TS IntelliSense on web #183684

Closed
2 tasks done
mjbvz opened this issue May 28, 2023 · 1 comment
Closed
2 tasks done

Test project wide JS/TS IntelliSense on web #183684

mjbvz opened this issue May 28, 2023 · 1 comment

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented May 28, 2023

Test for #170920

Complexity: 4

Create Issue


Summary

We've enabled project wide IntelliSense on web for JS/TS projects with a key limitations. More importantly, all semantic errors are currently disabled until we ship support for type acquisition on web. Additionally, intellisense will not work for third party packages for the same reason

Testing

For this test plan item, try exploring that works and what doesn't with this feature. You can use https://insiders.vscode.dev/github/microsoft/vscode-markdown-languageservice to test

Try our Intellisense features like find all references and go to definition, along with auto imports. Also try changing the tsconfig.json (such as turning on/off certain strictness errors) and make sure these changes are picked up

You can disable project wide Intellisense on web by setting typescript.tsserver.web.projectWideIntellisense.enabled

@mjbvz mjbvz added this to the May 2023 milestone May 28, 2023
@ghost ghost assigned bpasero and Tyriar May 30, 2023
@bpasero bpasero removed their assignment May 30, 2023
@bpasero
Copy link
Member

bpasero commented May 30, 2023

So 💯 useful! I tested in Chrome. I was not sure how to test changes to tsconfig.json though, given we do not seem to show any warnings.

@Tyriar Tyriar removed their assignment May 31, 2023
@Tyriar Tyriar closed this as completed May 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants