Skip to content

Error when switching profiles when dirty notebook is open #180822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexr00 opened this issue Apr 25, 2023 · 7 comments
Closed

Error when switching profiles when dirty notebook is open #180822

alexr00 opened this issue Apr 25, 2023 · 7 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster notebook

Comments

@alexr00
Copy link
Member

alexr00 commented Apr 25, 2023

Testing #180767

While testing the "github-issues" I saw the following error when switch from my default profile (where the extension is installed) to my test profile (where the extension is not installed):

image

@bpasero
Copy link
Member

bpasero commented Apr 25, 2023

To clarify: the notification just appeared when you switched profiles or did you also trigger save? I think #180514 would help here.

@bpasero bpasero added info-needed Issue requires more information from poster notebook labels Apr 25, 2023
@alexr00
Copy link
Member Author

alexr00 commented Apr 26, 2023

I don't think I triggered save, just switched profiles.

@bpasero
Copy link
Member

bpasero commented Apr 26, 2023

I cannot reproduce, do you still?

@alexr00
Copy link
Member Author

alexr00 commented Apr 26, 2023

Yes, I can still repro the issue. Full steps:

  1. Have default profile with GitHub Issues Notebook installed
  2. Have profile A where GitHub Issues Notebook is not installed and where auto save is on
  3. Turn off auto save only in the default profile
  4. Use your default profile
  5. Open a GitHub issues notebook and make a change in it so that the file is dirty. Do not save
  6. Switch to profile A

@bpasero
Copy link
Member

bpasero commented Apr 26, 2023

The notebook changes its content when you switch profiles and that is the reason.

@bpasero
Copy link
Member

bpasero commented Apr 26, 2023

/duplicate #180823

@vscodenpa vscodenpa added the *duplicate Issue identified as a duplicate of another issue(s) label Apr 26, 2023
@vscodenpa
Copy link

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Apr 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster notebook
Projects
None yet
Development

No branches or pull requests

4 participants