Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[perf] terminal provideLinks #174040

Closed
jrieken opened this issue Feb 10, 2023 · 2 comments
Closed

[perf] terminal provideLinks #174040

jrieken opened this issue Feb 10, 2023 · 2 comments
Assignees
Labels
freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues invalid Issue identified as not relevant or not valid terminal-links
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Feb 10, 2023

re #170954

  • stable 1.75.0
  • checking the monacoworkbench/unresponsive.sample-event

(each entry is a separate event but they might all share the same cause)



Fn Callers dcount_VSCodeMachineId avg_TotalTime
addEventListener d#workbench.desktop.main.js:90<s#workbench.desktop.main.js:90<hover#workbench.desktop.main.js:1203<_linkHover#xterm.js:1<_handleNewLink#xterm.js:1<_checkLinkProviderResult#xterm.js:1<(anonymous)#xterm.js:1<provideLinks#workbench.desktop.main.js:1203 58 4233.8175182481755
c#workbench.desktop.main.js:1231 detect#workbench.desktop.main.js:1231<h#workbench.desktop.main.js:1203<provideLinks#workbench.desktop.main.js:1203<_askForLink#xterm.js:1<(anonymous)#xterm.js:1<fire#xterm.js:1<_renderRows#xterm.js:1<(anonymous)#xterm.js:1<_innerRefresh#xterm.js:1<(anonymous)#xterm.js:1 42 339.01428571428573
addEventListener d#workbench.desktop.main.js:90,25586<s#workbench.desktop.main.js:90,25795<hover#workbench.desktop.main.js:1092,5176<_linkHover#xterm.js:1,15376<_handleNewLink#xterm.js:1,13490<_checkLinkProviderResult#xterm.js:1,12199<(anonymous)#xterm.js:1,11506<provideLinks#workbench.desktop.main.js:1092,6962 32 5189.8611111111113
getBoundingClientRect i#xterm.js:1<t.getCoords#xterm.js:1<getCoords#xterm.js:1<_positionFromMouseEvent#xterm.js:1<_handleNewLink#xterm.js:1<_checkLinkProviderResult#xterm.js:1<(anonymous)#xterm.js:1<provideLinks#workbench.desktop.main.js:1203 29 190.18181818181819
c#workbench.desktop.main.js:1120,20208 detect#workbench.desktop.main.js:1120,19514<h#workbench.desktop.main.js:1092,7040<provideLinks#workbench.desktop.main.js:1092,6962<_askForLink#xterm.js:1,11082<(anonymous)#xterm.js:1,15056<fire#xterm.js:1,136295<_renderRows#xterm.js:1,99952<(anonymous)#xterm.js:1,97951<_innerRefresh#xterm.js:1,19939<(anonymous)#xterm.js:1,19898 26 478.62790697674421
@jrieken jrieken added the freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues label Feb 10, 2023
@jrieken
Copy link
Member Author

jrieken commented Feb 10, 2023

Reading help 📖

  • The Fn column is the function that the profiler identified as slow (see avg_TotalTime for the avg durations and dcount... for the number of affected machines)
  • The Callers column is the "heaviest" call-stack into that function, each calling function is separated by the < character (kusto escape gymnastics...)

@Tyriar Tyriar added this to the March 2023 milestone Feb 10, 2023
@jrieken
Copy link
Member Author

jrieken commented Feb 20, 2023

While digging into #174039 I realised that I had queried kusto wrongly - the data was pulled for stable and 1.75 insiders. For the latter we have seen and fixed this issue. When querying properly (only for 1.75.0 and 1.75.1) this doesn't show up anymore

@jrieken jrieken closed this as completed Feb 20, 2023
@jrieken jrieken added the invalid Issue identified as not relevant or not valid label Feb 20, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues invalid Issue identified as not relevant or not valid terminal-links
Projects
None yet
Development

No branches or pull requests

2 participants