Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tree find controls more discoverable #173742

Open
Eskibear opened this issue Feb 8, 2023 · 3 comments
Open

Make tree find controls more discoverable #173742

Eskibear opened this issue Feb 8, 2023 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality tree-widget Tree widget issues
Milestone

Comments

@Eskibear
Copy link
Member

Eskibear commented Feb 8, 2023

The Find control in tree view is very useful and highly requested by the community, but still a lot of people are not aware that we already have it in vscode. For the moment, to find something in tree view, you have to

  • select an item to focus on the tree view
  • press ctrl/cmd + F

To expose the feature more, can we add an option to show a button on view/title as below?

The behavior will look like below.

find-button.mp4

(I mimic the behavior by calling commands viewId.focus and list.find in above demo...but to add the buttons for multiple views, I have to do that repeatedly registering multiple commands).

As this is a generic feature for all tree views, I think it probably we can add a new option showFindControl in TreeViewOptions, just like how we add "showCollapseAll" button. WDYT?

vscode/src/vscode-dts/vscode.d.ts

Lines 10349 to 10352 in a7d49b0

/**
* Whether to show collapse all action or not.
*/
showCollapseAll?: boolean;

@alexr00 alexr00 added feature-request Request for new features or functionality tree-views Extension tree view issues labels Feb 8, 2023
@alexr00 alexr00 added this to the Backlog Candidates milestone Feb 8, 2023
@joaomoreno joaomoreno added tree-widget Tree widget issues and removed tree-views Extension tree view issues labels Feb 17, 2023
@VSCodeTriageBot VSCodeTriageBot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 11, 2023
@isidorn
Copy link
Contributor

isidorn commented May 5, 2023

Let's reopen this one and assign to backlog since we have been getting consistent feedback from extension authors that Find is not discoverable in the Custom Trees.

@isidorn isidorn reopened this May 5, 2023
@isidorn isidorn modified the milestones: Backlog Candidates, Backlog May 5, 2023
@microsoft microsoft deleted a comment from VSCodeTriageBot May 5, 2023
@microsoft microsoft deleted a comment from VSCodeTriageBot May 5, 2023
@microsoft microsoft deleted a comment from VSCodeTriageBot May 5, 2023
@joaomoreno joaomoreno removed their assignment May 11, 2023
@joaomoreno joaomoreno changed the title Add a button to show Find control in tree view Make tree find controls more discoverable Mar 27, 2024
@benibenj benibenj self-assigned this May 15, 2024
@LucaGabi
Copy link

LucaGabi commented May 22, 2024

Regarding #213055: please consider having an input text to filter like in this image (not only for the outline view but also for breadcrumbs) because this is in my opinion a very common action a developer dose to move easy around the code:
image

@RedCMD
Copy link
Contributor

RedCMD commented May 22, 2024

and allow the extension to prefill/modify the find/filter field

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality tree-widget Tree widget issues
Projects
None yet
Development

No branches or pull requests

9 participants