Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Simplified devcontainer.json for vscode repository #172017

Closed
3 tasks
chrmarti opened this issue Jan 23, 2023 · 8 comments
Closed
3 tasks

Test: Simplified devcontainer.json for vscode repository #172017

chrmarti opened this issue Jan 23, 2023 · 8 comments
Labels
engineering VS Code - Build / issue tracking / etc. testplan-item
Milestone

Comments

@chrmarti
Copy link
Collaborator

chrmarti commented Jan 23, 2023

Refs: #170969

  • macOS
  • linux
  • windows

Complexity: 3

Create Issue


NOTE: Currently blocked by #168655. Please hold off testing until we have fixed that.

Follow https://github.com/microsoft/vscode/blob/main/.devcontainer/README.md to develop VS Code in a dev container.

@chrmarti chrmarti added this to the January 2023 milestone Jan 23, 2023
@chrmarti chrmarti added the engineering VS Code - Build / issue tracking / etc. label Jan 23, 2023
@chrmarti
Copy link
Collaborator Author

Moving to next milestone as we don't have the required fix to test this yet.

@hediet
Copy link
Member

hediet commented Feb 21, 2023

I chose the "Code - OSS" devcontainer (without WSL) and got a bunch of issues:

"Configuring..." got stuck (or takes more than 10 minutes):
image

"yarn install --force" crashed (after updating docker & wsl it worked though):
image

yarn watch failed:
image

Then I tried to clone vscode in WSL and this time chose "VS Code" devcontainer.

This time, a window opened, but it also crashed:

image

@andreamah
Copy link
Contributor

NOTE: Currently blocked by #168655. Please hold off testing until we have fixed that.

Does this still apply? I noticed that this might be an old message that was posted before the TPI was assigned for this round of testing.

@hediet
Copy link
Member

hediet commented Feb 21, 2023

It still applies

@TylerLeonhardt TylerLeonhardt assigned rzhao271 and unassigned hediet Feb 21, 2023
@rzhao271
Copy link
Contributor

rzhao271 commented Feb 21, 2023

I chose the VS Code devcontainer and got the same loader crash as Henning.
I noticed that the icon's also unaligned:

Code OSS on WSL icon seems to sink halfway into the bottom of the screen

Windows 11, opened the remote WSL folder and then reopened it in devcontainers.
Devcontainers extension version v0.280.0
WSL extension version v0.76.0
WSL distro Ubuntu 20.04.4 LTS

@rzhao271 rzhao271 removed their assignment Feb 21, 2023
@andreamah
Copy link
Contributor

I'm a bit confused, are we supposed to be testing this item yet? I had the impression, based on the description, that this was not ready for testing yet.

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Feb 22, 2023

Based on what I'm reading, this test plan does not seem ready yet. @chrmarti can you please chime in and move this issue out if it's not ready?

@chrmarti
Copy link
Collaborator Author

Sorry, this should not have been assigned as TPI. Closing until the blocking bug is fixed.

@chrmarti chrmarti removed this from the February 2023 milestone Feb 22, 2023
@vscodenpa vscodenpa added this to the February 2023 milestone Feb 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engineering VS Code - Build / issue tracking / etc. testplan-item
Projects
None yet
Development

No branches or pull requests

12 participants