Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[perf] Investigate getOverrideValue usages in renderer #170877

Closed
jrieken opened this issue Jan 9, 2023 · 5 comments
Closed

[perf] Investigate getOverrideValue usages in renderer #170877

jrieken opened this issue Jan 9, 2023 · 5 comments
Assignees
@rzhao271 @sandy081
Labels
freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues

Comments

@jrieken
Copy link
Member

jrieken commented Jan 9, 2023 •
edited
Loading

re #170954

Automatic renderer profiling shows many calls/usages of getOverrideValue. The call stack hints towards the settings editor, e.g this is a sample for the 727d2d32aea02baf7d13fa38787e8ed64dd858d0 insiders release

inspect#workbench.desktop.main.js:641:13951
<inspect#workbench.desktop.main.js:1191:2877
<inspect#workbench.desktop.main.js:2275:21560
<o#workbench.desktop.main.js:2031:4115
<t#workbench.desktop.main.js:2031:3814
<(anonymous)#workbench.desktop.main.js:2031:3595
<p#workbench.desktop.main.js:2031:3471
<(anonymous)#workbench.desktop.main.js:2031:3720
<p#workbench.desktop.main.js:2031:3471
<(anonymous)#workbench.desktop.main.js:2031:3720
<p#workbench.desktop.main.js:2031:3471
<update#workbench.desktop.main.js:2031:2777
<Gc#workbench.desktop.main.js:2289:56620
@jrieken jrieken changed the title [perf] Investigate [perf] Investigate getOverrideValue usages in renderer Jan 9, 2023
@jrieken jrieken added the freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues label Jan 9, 2023
@sandy081
Copy link
Member

@rzhao271 Can you please start investigating this beginning with settings editor and let me know if there is anything to be done in the model, say a way of getting values in bulk for eg?

@jrieken
Copy link
Member Author

jrieken commented Jan 11, 2023

Might have been a fluke - this showed for one insiders build but not for yesterdays...

@Jwhitmer0110 Jwhitmer0110 mentioned this issue Jan 12, 2023
Closed
@rzhao271
Copy link
Contributor

Let me know if this shows up again.
I believe that inspect is called when switching scopes (like User to Workspace), and when a language filter is applied.

@rzhao271 rzhao271 added the info-needed Issue requires more information from poster label Jan 24, 2023
@jrieken jrieken removed the info-needed Issue requires more information from poster label Jan 25, 2023
@jrieken
Copy link
Member Author

jrieken commented Jan 25, 2023

Let me know if this shows up again.

Even better - you can now just check error telemetry for this function

@rzhao271
Copy link
Contributor

rzhao271 commented Dec 7, 2023

I believe this is fixed now

@rzhao271 rzhao271 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rzhao271 rzhao271

@sandy081 sandy081

Labels
freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jrieken @rzhao271 @sandy081 @aiday-mar