Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle GitHub's Secret Scanning Push Protection #169355

Closed
digitarald opened this issue Dec 16, 2022 · 1 comment
Closed

Handle GitHub's Secret Scanning Push Protection #169355

digitarald opened this issue Dec 16, 2022 · 1 comment
Assignees
@digitarald @lszomoru
Labels
feature-request Request for new features or functionality github Github extension
Milestone
December / Januar...

Comments

@digitarald
Copy link
Contributor

digitarald commented Dec 16, 2022 •
edited
Loading

Part of #164105.

Provide a notification with one-click actions to Secret Scanning Push Protection.

When a push fails, VS Code should explain the issue and offer to:

  1. Revert the bad commit which added the secret (and open the file)
  2. Open the file that has the commit
  3. Point to the web page for unblocking the commit

Related: GitHub Advanced Security customers can now push protect their custom patterns, which will have a much higher false positive rate as enterprise teams own the rules.
@digitarald digitarald added feature-request Request for new features or functionality github Github extension labels Dec 16, 2022
@digitarald digitarald mentioned this issue Dec 16, 2022
Closed
@digitarald digitarald added this to the January 2023 milestone Dec 16, 2022
@lszomoru lszomoru modified the milestones: January 2023, Backlog, On Deck Jan 11, 2023
@kieferrm kieferrm mentioned this issue May 9, 2023
Closed
76 tasks
@kieferrm kieferrm mentioned this issue Jun 11, 2023
Closed
74 tasks
@lszomoru
Copy link
Member

Basic handling for push protection was added in https://github.com/microsoft/vscode-internalbacklog/issues/3541.
As there is no GutHub REST API, there is not much more we can do at the moment.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@digitarald digitarald

@lszomoru lszomoru

Labels
feature-request Request for new features or functionality github Github extension
Projects
None yet
Milestone
December / January 2024
Development

No branches or pull requests
3 participants
@digitarald @lszomoru @aiday-mar