Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate 1.75.0-insider slowdown on perf bot #168639

Closed
jrieken opened this issue Dec 9, 2022 · 9 comments
Closed

Investigate 1.75.0-insider slowdown on perf bot #168639

jrieken opened this issue Dec 9, 2022 · 9 comments
Assignees
@bpasero @jrieken
Labels
perf perf-startup
Milestone
January 2023

Comments

@jrieken
Copy link
Member

jrieken commented Dec 9, 2022

The perf bot shows a slowdown when we changed from 1.74.0 to 1.75.0. We should figure out if this is a fluke or some unwanted changed that happened during debt-week
@jrieken jrieken self-assigned this Dec 9, 2022
@jrieken jrieken added this to the January 2023 milestone Dec 9, 2022
@jrieken
Copy link
Member Author

jrieken commented Dec 20, 2022

The perf machine data shows a slowdown when processing configuration defaults and just configurations. That would explain a little bit but not all of the slowdown

Screenshot 2022-12-20 at 15 47 29

Screenshot 2022-12-20 at 15 47 55

@jrieken
Copy link
Member Author

jrieken commented Dec 20, 2022

@sandy081 Were there changes in the configuration service (during the 1.74 to 1.75 debt week) that could explain this or should I fish for a new listener here?

@sandy081
Copy link
Member

No changes in config land except this which is adding log statements.

This was referenced Dec 21, 2022
Merged
Closed
@jrieken
Copy link
Member Author

jrieken commented Jan 3, 2023

Good news: great improvements wrt handling contribution points.

Screenshot 2023-01-03 at 09 57 01

@jrieken
Copy link
Member Author

jrieken commented Jan 3, 2023

Bad news: something happens with added a big delay between the didCreateWorkbenchContributions/3 and willHandleExtensionPoints phases

Screenshot 2023-01-03 at 09 58 12

@sandy081 sandy081 self-assigned this Jan 3, 2023
@sandy081
Copy link
Member

sandy081 commented Jan 3, 2023

Caused by e90f48f#diff-72bc8a9f7335192506e81a38f38cec5f7438af42467722f97f1f57e58be2a372R516

Fix - #170446

@sandy081 sandy081 removed their assignment Jan 3, 2023
@kieferrm kieferrm mentioned this issue Jan 9, 2023
Closed
@bpasero bpasero self-assigned this Jan 9, 2023
@bpasero
Copy link
Member

bpasero commented Jan 16, 2023

I think this is solved:

Image

@jrieken
Copy link
Member Author

jrieken commented Jan 16, 2023

Confirmative - four fast builds in a row don't lie!

@jrieken
Copy link
Member Author

jrieken commented Jan 16, 2023

Thanks everyone for helping out on this!

@jrieken jrieken closed this as completed Jan 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

@jrieken jrieken

Labels
perf perf-startup
Projects
None yet
Milestone
January 2023
Development

No branches or pull requests
3 participants
@bpasero @jrieken @sandy081