Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsafe repositories refresh button missing #167605

Closed
gregvanl opened this issue Nov 29, 2022 · 3 comments
Closed

unsafe repositories refresh button missing #167605

gregvanl opened this issue Nov 29, 2022 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues *out-of-scope Posted issue is not in scope of VS Code polish Cleanup and polish issue

Comments

@gregvanl
Copy link

gregvanl commented Nov 29, 2022

Testing #167413

Following the test plan item for a single repository, if you add the folder to safe.directory via

git config --global --add safe.directory C:/Users/gregvanl/deleteMe/scenario1/vscode

There isn't a way to refresh the SCM view as there is no refresh button.

image

Of course, the workaround is just to reload the window, so maybe a nit

@gregvanl
Copy link
Author

gregvanl commented Nov 29, 2022

You can also get into an error state after removing the safe.directory value via

git config --global --unset-all safe.directory

The SCM refresh doesn't succeed and shows a Git error dialog:

image

@lszomoru lszomoru added git GIT issues polish Cleanup and polish issue bug Issue identified by VS Code Team member as probable bug labels Nov 30, 2022
@lszomoru lszomoru added this to the Backlog milestone Nov 30, 2022
@lszomoru
Copy link
Member

@gregvanl, thanks for the feedback. Ideally users will not be changing the configuration directly but I do agree that we should be handling these edge case more gracefully. I will tackle these paper cuts next milestone.

@lszomoru lszomoru modified the milestones: Backlog, December 2022 Nov 30, 2022
@lszomoru lszomoru modified the milestones: January 2023, Backlog Jan 11, 2023
@lszomoru lszomoru added the *out-of-scope Posted issue is not in scope of VS Code label Dec 12, 2023
@vscodenpa
Copy link

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding, and happy coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues *out-of-scope Posted issue is not in scope of VS Code polish Cleanup and polish issue
Projects
None yet
Development

No branches or pull requests

4 participants