Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to tab to dropdown for setting with enum values #167599

Closed
joyceerhl opened this issue Nov 29, 2022 · 4 comments
Closed

Unable to tab to dropdown for setting with enum values #167599

joyceerhl opened this issue Nov 29, 2022 · 4 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member settings-editor VS Code settings editor issues
Milestone

Comments

@joyceerhl
Copy link
Collaborator

Testing #167084

  1. Search for @lang:go editor spaces
  2. Tab to the settings list and tab twice on editor.defaultFoldingRangeProvider
  3. 🐛 tab focus jumps to the status bar, I'd expect it to jump to the enum dropdown
@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues confirmation-pending labels Dec 5, 2022
@rzhao271 rzhao271 added this to the Backlog milestone Dec 6, 2022
@rzhao271
Copy link
Contributor

rzhao271 commented Dec 7, 2022

This bug is interesting. If I press down up and then tab for step 2, I can then tab into the dropdown. If I just tab again, it goes to the status bar because it thinks the user wants to focus out of the entire listview and go to the next element, which happens to be the status bar.

In other words, when the user tabs from the Settings editor search bar to the first element in the listview, and presses tab again, we need to decide between focusing a child element of the first element in the listview, or navigating to another part of the editor.

Do you have ideas on what the tabbing behaviour should be in this case? I'm thinking that I can keep focus in the listview, and make it so that the user has to enable "Tab Moves Focus" to go to the next part of the editor, but I'd like to confirm. CC @isidorn

@rzhao271 rzhao271 added confirmed Issue has been confirmed by VS Code Team member and removed confirmation-pending labels Dec 7, 2022
@isidorn
Copy link
Contributor

isidorn commented Dec 8, 2022

I think that is a fair suggestion, since we already primarily use tab to navigate across the Settings UI
cc @meganrogge for her thoughts

@meganrogge
Copy link
Contributor

@rzhao271 that suggestion sounds good then we can see what the community thinks of it

@rzhao271 rzhao271 added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Feb 3, 2024
@rzhao271
Copy link
Contributor

Unable to repro now

@rzhao271 rzhao271 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member settings-editor VS Code settings editor issues
Projects
None yet
Development

No branches or pull requests

4 participants