Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand "Not synced" outline #167538

Open
chrmarti opened this issue Nov 29, 2022 · 2 comments
Open

Expand "Not synced" outline #167538

chrmarti opened this issue Nov 29, 2022 · 2 comments
Assignees
@rzhao271
Labels
bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue settings-editor VS Code settings editor issues
Milestone
January 2025

Comments

@chrmarti
Copy link
Collaborator

chrmarti commented Nov 29, 2022 •
edited
Loading

Testing #167084

The outline on "Not synced" looks to small (this is on Linux):
image
@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues labels Nov 30, 2022
@rzhao271 rzhao271 modified the milestones: December 2022, January 2023 Nov 30, 2022
@rzhao271 rzhao271 added the polish Cleanup and polish issue label Dec 6, 2022
@rzhao271
Copy link
Contributor

The current outline-offset is -1px.
I've attached an example of how the focus outline looks when the outline-offset is 0px. I think the outline is too high due to the height of the indicator trying to match the height of the element containing the text Editor: Tab Size, but that the spacing of the sides is better.
Example of focus outline on a Modified Elsewhere label when the outline-offset is set to 0px instead of -1px.

@rzhao271 rzhao271 modified the milestones: February 2023, On Deck Feb 21, 2023
@rzhao271
Copy link
Contributor

Looking at the issue again, I think the issue is there is not enough start and end padding.

@rzhao271 rzhao271 modified the milestones: On Deck, January 2025 Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rzhao271 rzhao271

Labels
bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue settings-editor VS Code settings editor issues
Projects
None yet
Milestone
January 2025
Development

No branches or pull requests
2 participants
@rzhao271 @chrmarti