Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "Mark as Handled" with "Ignore" actions #165696

Closed
hediet opened this issue Nov 7, 2022 · 3 comments
Closed

Replace "Mark as Handled" with "Ignore" actions #165696

hediet opened this issue Nov 7, 2022 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug feature-request Request for new features or functionality merge-editor verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@hediet
Copy link
Member

hediet commented Nov 7, 2022

Code_-_Insiders_509paNjFOr

Verification steps:

  • Open this merge conflict using the dev command:
{
    "languageId": "typescript",
    "base": "\t\t// Update: Text\n\t\tif (!this.entry || entry.text !== this.entry.text) {\n\t\t\tthis.label.text = entry.text;\n\n\t\t\tif (entry.text) {\n\t\t\t\tshow(this.labelContainer);\n\t\t\t} else {\n\t\t\t\t//some\n\t\t\t\thide(this.labelContainer);\n\t\t\t}\n\t\t}\n\n\t\t// Update: ARIA label\n\t\t//\n\t\t// Set the aria label on both elements so screen readers would read\n\t\t// the correct thing without duplication #96210\n\n\t\tif (!this.en",
    "input1": "\t\t// Update: Text\n\t\tif (!this.entry || entry.text !== this.entry.text) {\n\t\t\tthis.label.text = entry.text;\n\n\t\t\tif (entry.text) { // 1\n\t\t\t\t// Additional line 1\n\t\t\t\t// Additional line 2\n\t\t\t\t// Additional line 3\n\t\t\t\tshow(this.labelContainer);a\n\n\t\t\t\t//\n\t\t\t\thide(this.labelContainer); // 3\n\t\t\t}\n\t\t}\n\n\t\t// Update: ARIA label\n\t\t//\n\t\t// Set the aria label on both elements so screen readers would read\n\t\t// the correct thing without duplication #96210\n\n\t\tif (!this.en",
    "input2": "\t\t// Update: Text\n\t\tif (!this.entry || entry.text !== this.entry.text) {\n\t\t\tthis.label.text = entry.text;\n\n\t\t\tif (entry.foo) {show(this.labelContainer);\n\t\t\t} else { // 2\n\t\t\t\t// some\n\t\t\t\t// additional\n\t\t\t\t// stuff\n\t\t\t\thide(this.labelContainer);\n\t\t\t}\n\t\t}\n\n\t\t// Update: ARIA label\n\t\t//\n\t\t// Set the aria label on both elements so screen readers would read\n\t\t// the correct thing without duplication #96210\n\n\t\tif (!this.en",
    "result": "\t\t// Update: Text\n\t\tif (!this.entry || entry.text !== this.entry.text) {\n\t\t\tthis.label.text = entry.text;\n\n\t\t\tif (entry.text) {\n\t\t\t\tshow(this.labelContainer);\n\t\t\t} else {\n\t\t\t\t//some\n\t\t\t\thide(this.labelContainer);\n\t\t\t}\n\t\t}\n\n\t\t// Update: ARIA label\n\t\t//\n\t\t// Set the aria label on both elements so screen readers would read\n\t\t// the correct thing without duplication #96210\n\n\t\tif (!this.en",
    "initialResult": "\t\t// Update: Text\n\t\tif (!this.entry || entry.text !== this.entry.text) {\n\t\t\tthis.label.text = entry.text;\n\n\t\t\tif (entry.text) {\n\t\t\t\tshow(this.labelContainer);\n\t\t\t} else {\n\t\t\t\t//some\n\t\t\t\thide(this.labelContainer);\n\t\t\t}\n\t\t}\n\n\t\t// Update: ARIA label\n\t\t//\n\t\t// Set the aria label on both elements so screen readers would read\n\t\t// the correct thing without duplication #96210\n\n\t\tif (!this.en"
}
  • verify there are ignore buttons as in the gif and they work as expected
@hediet hediet added bug Issue identified by VS Code Team member as probable bug feature-request Request for new features or functionality merge-editor labels Nov 7, 2022
@hediet hediet self-assigned this Nov 7, 2022
@hediet hediet added the verification-needed Verification of issue is requested label Nov 7, 2022
@hediet
Copy link
Member Author

hediet commented Nov 7, 2022

Implemented.

@sanket-bhalerao
Copy link

@hediet,
I find it peculiar that I have to ignore the change from incoming after I accepted it on the current side. is this intended?

@hediet
Copy link
Member Author

hediet commented Nov 16, 2022

We changed this just yesterday back to the previous behavior (where you don't need to click on ignore), the change should be available in todays insiders!

@hediet hediet added this to the November 2022 milestone Nov 28, 2022
@isidorn isidorn added the verified Verification succeeded label Nov 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug feature-request Request for new features or functionality merge-editor verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants