Test: Policy setting indicators in the Settings editor

[rzhao271]

Refs: #157564

• macOS @eleanorjboyd
• linux @alexr00

Complexity: 3

Authors: @rzhao271, @sandy081

Create Issue

---

The look of policy-managed settings is now different in the Settings editor. This TPI is intentionally only for macOS and Linux because they support the --__enable-file-policy flag.

1. One can find the directory of the argv.json file by running the "Preferences: Configure Runtime Arguments" command, followed by the "File: Reveal in File Explorer" command. In the same folder as argv.json, set up a file policy.json with the following content:

{
    "UpdateMode": "none"
}

2. Open code-insiders from a terminal with the command code-insiders --__enable-file-policy
3. In the Settings editor, search for update mode.
4. The update.mode setting should show up with an indicator. The indicator currently has a warning icon on it to be extra noticeable.
5. A user should be able to change the setting value of a policy setting and have the new value reflected in the Settings editor. The JSON file should also be updated with the new value. However, the setting in the JSON file should have a warning on it also saying that the setting cannot be applied due to it being managed by a policy.
   • If step 5 fails, that's a bug. Also try changing the update.mode setting directly in the User settings.json file. One should be able to successfully save the settings.json file after, but the setting itself should have a warning or be faded out.
6. Use a screenreader to focus onto the policy setting in the Settings editor. Screenreaders currently cannot focus onto the indicators themselves, but when they focus onto the setting, a paraphrased version of the indicator information should be read out.

[eleanorjboyd]

Hi! Two questions - should I be able to change the "updateMode" setting in the settings UI? Mine gives the error: Unable to write update.mode because it is configured in system policy. which seems correct I just wanted to check. Additionally should I see the "updateMode" reflected in the settings.json file for the user settings?

[rzhao271]

Hi, the setting should be writable still. It's a bug that the setting isn't writable from the Settings editor, but if the whole feature seems confusing, you can also create an issue with that feedback.

"updateMode" should be reflected in the JSON file after adjusting the setting in the Settings editor. Can the setting be modified by editing the user settings.json file directly?

[eleanorjboyd]

Here is what I see- I go into change that setting and I get this error pop up and then I do not see updateMode in the settings.json file. To clarify I created the policy.json myself and the .vscode-insiders folder is not listed in my file explorer in VS Code but instead I found it through finder. I am able to change the UpdateMode in the policy.json file and I get a pop up on VS Code that says A setting has changed that requires a restart to take effect. - which on reload the new value does display in the settings UI.

[rzhao271]

That makes sense. I have modified the TPI and added some clarification steps.

[eleanorjboyd]

screen reader for mac works as expected 👍

[alexr00]

I can't get a screen reader working with a VM, but everything else works well!