Install language pack notification always show

[tjx666]

After I install Chinese language pack, uninstall it, every time I open a new window, always notice it.

Version: 1.73.0-insider (Universal)
Commit: 7ef8e6b87a2a5a25ba1ef946bd1640ca3510956c
Date: 2022-10-14T05:18:26.756Z
Electron: 19.0.17
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Darwin x64 21.6.0
Sandboxed: Yes

[rzhao271]

The code now tries to use the system language to determine whether there could be a language pack to recommend to users, but I agree that showing it every new window is excessive.

[TylerLeonhardt]

@tjx666 2 questions:

1. when you run Configure Display Language what is the "Current" language? English?
2. when you run Configure Runtime Arguments what do you have set for "locale" (if any) and if it's not en can you set it to en and let me know what happens for you

@rzhao271 I feel like your change #159958 should address this 🤔

[tjx666]

It's strage that I had never manualy modified the argv.json

[TylerLeonhardt]

@tjx666 yeah I think a bug in this is that uninstalling the language pack should remove the locale property or set it to English...

Do you get what you want if you set the locale in the args to en?

[tjx666]

@TylerLeonhardt I had set never notify again, so I can't check that....

[tjx666]

After I install the latest insider version. This issue still exists:

2022-11-10.01.19.28.mov

[tjx666]

This is very annoying. @TylerLeonhardt Any ideas about it?
I had download many times latest vscode insiders, every time this issue can be reproduced.

2022-12-06.00.44.36.mov

[TylerLeonhardt]

@tjx666 coming back from the holidays... there should be a "Don't show again" option under the little gear icon. Do you see that option? It's suppose to make this prompt go away forever. Does it?

[tjx666]

@tjx666 coming back from the holidays... there should be a "Don't show again" option under the little gear icon. Do you see that option? It's suppose to make this prompt go away forever. Does it?

Yes

[TylerLeonhardt]

@tjx666 since that allows you to control whether you see this notification in the future, I feel like this issue is covered and we can close it.... unless I'm misunderstanding the issue.