Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web: Welcome banner appears below titlebar #162424

Closed
joaomoreno opened this issue Sep 30, 2022 · 2 comments
Closed

Web: Welcome banner appears below titlebar #162424

joaomoreno opened this issue Sep 30, 2022 · 2 comments
Assignees
@lszomoru @sbatten
Labels
bug Issue identified by VS Code Team member as probable bug titlebar VS Code main title bar issues verified Verification succeeded web Issues related to running VSCode in the web
Milestone
October 2022

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Sep 30, 2022 •
edited
Loading

screenshot

On the web, should it appear always at the top?

Or should we separate the welcome banner from the cookies banner in vscode.dev, and just make the latter an isolated part of vscode.dev?
@joaomoreno joaomoreno mentioned this issue Sep 30, 2022
Closed
@sbatten
Copy link
Member

sbatten commented Oct 14, 2022

I have pushed a change to move the banner above the title bar in the web only.

@sbatten sbatten closed this as completed Oct 14, 2022
@sbatten sbatten added bug Issue identified by VS Code Team member as probable bug titlebar VS Code main title bar issues web Issues related to running VSCode in the web labels Oct 14, 2022
@sbatten sbatten added this to the October 2022 milestone Oct 14, 2022
@joyceerhl joyceerhl added the verified Verification succeeded label Oct 26, 2022
@joyceerhl
Copy link
Collaborator

👍
image

@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lszomoru lszomoru

@sbatten sbatten

Labels
bug Issue identified by VS Code Team member as probable bug titlebar VS Code main title bar issues verified Verification succeeded web Issues related to running VSCode in the web
Projects
None yet
Milestone
October 2022
Development

No branches or pull requests
4 participants
@joaomoreno @lszomoru @sbatten @joyceerhl