-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continue On... accessible through the Remote indicator #162259
Comments
It looks like you are possibly in an empty workspace here (since you're in https://insiders.vscode.dev and there is no Continue On from Remote Repositories). Continue On is currently disabled in this scenario because I don't think we have any Continue On options which allow you to start in an empty workspace--currently they all assume you have a git or remote GitHub repository. Is this an empty workspace or a local folder here? What would you expect to be able to do in this scenario? For the location of Continue On in the remote indicator, there was similar feedback here: #162119 |
I also think the remote menu is a good place for "Continue on". However I also think that "Edit Sessions" and "Continue on" should be closer together and not disconnected. I find that "Edit Sessions" is the technical requirement to get "Continue on" working, but it is not so obvious. I wonder if we should rather hide the "Edit Sessions" entries and make this all acessible via the concept of "Continue On". So the naming would be along the lines of:
|
I explored three options for surfacing Continue On through the remote indicator in desktop, since it's currently not there at all (and these proposals would also apply to the remote indicator in web). I think we would still want to retain the Continue Working On command which presents all options in a single list when entering the feature via the terminal and debug welcome views, so this mostly relates to how Continue On options are presented in the remote indicator. Single top-level Continue On entryThis is the same as what we have in VS Code for the Web today, i.e. a single Continue Working On entry in the remote indicator that would now be present in web, desktop, and remote windows. It's compact but requires two clicks to get to the list. top-level-continue-on.mp4Separate Continue On categoryThis flattens the list of Continue On items into the top-level remote indicator, removing the need for two clicks, but it means that extensions which have their own remote group and a continue on contribution will appear in two different groups in this list, which can be confusing. continue-on-group.mp4Continue On integrated into each remote groupThis integrates the continue on options into each extension's remote group. (NB there's an adoption cost here since the contributions would have different display names depending if they're shown in the Continue Working On... picker or inline with the extension's remote group) integrated-continue-on.mp4cc for feedback and suggestions @aeschli @daviddossett |
At a glance, I prefer option
|
To me, the remote menu is more for connecting to another machine. Many actions open a new window and that window is a remote window. |
It's true that Continue On from web RemoteHub to desktop RemoteHub / desktop git clone or from desktop RemoteHub to a desktop git clone don't relate to connecting to another machine per se, so I can see how it may make sense to instead move it to the File menu: It doesn't feel like a fit for Open Recent to me though, since Continue On transfers your current working context to a new development environment, and 'recent' implies a window I have already visited before. |
Can we UX discuss this Wednesday before making a decision? |
Yes definitely, I intentionally made the impl a draft PR. |
@brettcannon had related feedback on wanting a
|
I have added support for one-step actions like @aeschli since some but not all Continue On options deal with opening a remote, what would you think of surfacing the one-step actions which relate to remotes in the remote indicator in their specific categories? i.e. Dev containers and Codespaces would have actions in the Dev containers and Codespaces categories which say 'Continue on in a (Codespace | Dev Container)'. |
In fact now I realize that it's about the reopening the current folder in a remote location. The same what already have for Dev containers ( |
I observe myself clicking the remote indicator to get to "Continue On" and it's not there. Rather than a generic "Continue On" entry it might make sense to have for each remote group a separate one. Like "Continue on in a Codespace" in the second group.
The text was updated successfully, but these errors were encountered: