Under conpty, shell integration decorations can be incorrectly positioned

[alexr00]

Testing #153365

1. Open microsoft/vscode
2. Start the default VS Code build task
3. Make some errors
4. The problem decorations are one line too high:

---

Update from @Tyriar: This tracks the common set of issues that come from conpty doing its own "rendering" and not guaranteeing the position of the shell integration sequences. Upstream issue: microsoft/terminal#8698

[meganrogge]

on windows?

[Tyriar]

Yep that's Windows, this was by designed to put it on the beginsPattern right?

[meganrogge]

on mac

[alexr00]

Yes, it's Windows.

[Tyriar]

This seems to be working for me:

I did see some weird behavior when resizing the width of the terminal earlier, that's probably too risky to fix this late in endgame.

[Tyriar]

More info on this: When conpty supports "passthrough" of the OSC 133/633 sequences this should be fixed. Currently we have a bunch of heuristics that try to fix up incorrectly places sequences as the position isn't guaranteed to be correct since they are not output during the render phase. Upstream issue: microsoft/terminal#8698

One idea we could do is more aggressively reading the buffer and re-positioning the decorations, I'm a little worried about the performance overhead of doing that though.

[tisilent]

Same issue?

[Tyriar]

Closing this as out of scope as this will eventually get fixed in later versions if Windows and it's fairly low impact.